Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TraceLevel at -2 #1015

Closed
wants to merge 1 commit into from
Closed

Add TraceLevel at -2 #1015

wants to merge 1 commit into from

Conversation

slaxor
Copy link

@slaxor slaxor commented Sep 22, 2021

This adds a new loglevel (default switched off). The reasoning is:

  • Syslog does it
  • It is useful for i.e. outputting SQL results you would normally not
    give a rats ass about.

@slaxor
Add TraceLevel at -2
e069791 
This adds a new loglevel (default switched off). The reasoning is:
  - Syslog does it
  - It is useful for i.e. outputting SQL results you would normally not
  give a rats ass about.
@CLAassistant
Copy link

CLAassistant commented Sep 22, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@abhinav
Copy link
Collaborator

abhinav commented Nov 5, 2021

Hello, and thanks for your contribution.

This has come up a few times before.
Adding new levels to Zap is currently a breaking change,
and we do not want to tag a v2 release of Zap yet.

Refs: #749, #729, #933

We're tracking a v2 wishlist in #388,
but we're not really planning a breaking release yet.
We'd prefer to err on the side of stability.

Closing.

@abhinav abhinav closed this Nov 5, 2021
@abhinav abhinav mentioned this pull request Nov 5, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slaxor @CLAassistant @abhinav