Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support non-standard, rich error types #325

Merged
merged 4 commits into from
Feb 21, 2017
Merged

Support non-standard, rich error types #325

merged 4 commits into from
Feb 21, 2017

Commits on Feb 20, 2017

  1. Add github.com/pkg/errors to Glide manifest 

    This necessitates updating all dependencies.
    Akshay Shah committed Feb 20, 2017
    Configuration menu
    Copy the full SHA
    3350d32 View commit details
    Browse the repository at this point in the history

  2. Add support for pkg/errors 

    Users who take the time (and performance hit) of using Dave Cheney's errors
package should get rich, annotated errors and stacktraces in their logs.
However, that package is only one of a number of similar packages hasn't yet
committed to a stable API, so we don't want to take a direct dependency on it.

To support these sorts of packages, serialize errors that implement
`fmt.Formatter` differently from those that don't.
    Akshay Shah committed Feb 20, 2017
    Configuration menu
    Copy the full SHA
    d3c9525 View commit details
    Browse the repository at this point in the history

  3. Store verbose error under a separate key

    Akshay Shah committed Feb 20, 2017
    Configuration menu
    Copy the full SHA
    2059b8a View commit details
    Browse the repository at this point in the history

  4. Only include verbose error if different

    Akshay Shah committed Feb 20, 2017
    Configuration menu
    Copy the full SHA
    4105466 View commit details
    Browse the repository at this point in the history