Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build by switching to golang:1.17-alpine3.13 #4641

Merged

Conversation

vytautas-karpavicius
Copy link
Contributor

What changed?
Use different golang:1.17 variant that is based on alpine3.13 instead.
The newer version (3.14) broke our build with Operation not permitted errors.
Others are having similar issues: docker-library/php#1177

Why?
master build is failing after #4632

How did you test it?
docker build .

Potential risks

Release notes

Documentation Changes

@vytautas-karpavicius vytautas-karpavicius changed the title Fix build by swithcing to golang:1.17-alpine3.13 Fix build by switching to golang:1.17-alpine3.13 Nov 15, 2021
@coveralls
Copy link

coveralls commented Nov 15, 2021

Pull Request Test Coverage Report for Build 6dbdfaf8-b553-491a-b425-110e1fbb31f7

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 61 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.01%) to 56.881%

Files with Coverage Reduction New Missed Lines %
common/task/fifoTaskScheduler.go 2 87.63%
common/task/weightedRoundRobinTaskScheduler.go 2 89.64%
service/history/execution/mutable_state_builder.go 2 69.66%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 55.49%
common/persistence/nosql/nosqlplugin/cassandra/workflowUtils.go 8 78.08%
common/persistence/nosql/nosqlplugin/cassandra/tasks.go 14 72.8%
common/persistence/nosql/nosqlplugin/cassandra/workflowParsingUtils.go 14 87.9%
common/persistence/nosql/nosqlTaskStore.go 16 58.37%
Totals Coverage Status
Change from base Build a804659b-4150-4321-8ba1-79fb74fe3f15: -0.01%
Covered Lines: 82325
Relevant Lines: 144733

💛 - Coveralls

@wenerme
Copy link
Contributor

wenerme commented Nov 15, 2021

You better upgrade docker instead.

@longquanzheng
Copy link
Collaborator

longquanzheng commented Nov 15, 2021

You better upgrade docker instead.

Thanks for looking @wenerme
I didn't look at lots of the context. The build does work for me as I am using the newer version of docker.
Do you know any cons if using this alpine3.13 in the PR?

@wenerme
Copy link
Contributor

wenerme commented Nov 16, 2021

No obviously cons, but it's always better to use newer version, beside, alpine is about to release 3.15.

@longquanzheng
Copy link
Collaborator

No obviously cons, but it's always better to use newer version, beside, alpine is about to release 3.15.

Actually not just issue for local docker build, the master image releasing pipeline is also broken:
https://buildkite.com/uberopensource/cadence-server/builds/12484#7b0314ab-02c0-4231-bf50-0d1c62a176b4

I just approved it and let it go through. We can have a ticket to improve it later on.

@vytautas-karpavicius vytautas-karpavicius merged commit 4461fe0 into uber:master Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants