refactor: combine asus and surface builds with nvidia #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a WIP commit which shows has the first steps of asus/surface main images mostly working in a Containerfile and skipping main/main. The nvidia parts will be built in a second target. Github workflows have not yet been touched.
Original commit from ublue-os/asus repo: ublue-os/asus@d4b9b20
Original commit from ublue-os/surface repo: ublue-os/surface@ebc60d3
Original commits from ublue-os/surface: https://github.com/ublue-os/surface/commits/main/system_files/silverblue
Merges nvidia's install and post-install scripts to reduce number of files to edit.
bsherman
requested review from
castrojo,
noelmiller,
KyleGospo,
EyeCantCU and
p5
castrojo
approved these changes
Mar 27, 2024
KyleGospo
approved these changes
Mar 27, 2024
noelmiller
approved these changes
Mar 27, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
This is failing merge-checks due to container image registry permissions. I'll merge now, rename repo, fix perms, then do a manual run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines the Containerfiles, install scripts, system_files, and workflows from:
nvidia(this repo) will be renamed tohweand the other 4 repos will be archived.After this is merged and the repo is renamed all the container image packages MUST have permissions updated!