Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updates for 0.10.0: 'fct' as a map, move 'ucv' to payload #108

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

jsantell
Copy link
Contributor

@jsantell jsantell commented Jun 6, 2023

Another breaking change for 0.10.0

* 'fct' changed from array to map of JSON.
* 'ucv' moved from header to payload.
@jsantell jsantell requested review from cdata and a team as code owners June 6, 2023 17:41
@codecov-commenter
Copy link

Codecov Report

Merging #108 (8c30db8) into main (3d30ec8) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   57.10%   57.16%   +0.05%     
==========================================
  Files          24       24              
  Lines         802      803       +1     
  Branches      196      196              
==========================================
+ Hits          458      459       +1     
  Misses        206      206              
  Partials      138      138              
Impacted Files Coverage Δ
ucan/src/builder.rs 79.20% <100.00%> (+0.20%) ⬆️
ucan/src/ipld/ucan.rs 71.11% <100.00%> (ø)
ucan/src/ucan.rs 68.81% <100.00%> (ø)

Copy link
Member

@cdata cdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdata cdata merged commit ae19741 into ucan-wg:main Jun 6, 2023
@github-actions github-actions bot mentioned this pull request Jun 6, 2023
@jsantell jsantell deleted the pre-0.10.0 branch June 6, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants