Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sky130/Openroad Tutorial Fixes #1392

Merged
merged 48 commits into from
Mar 14, 2023
Merged

Sky130/Openroad Tutorial Fixes #1392

merged 48 commits into from
Mar 14, 2023

Conversation

nayiri-k
Copy link
Contributor

@nayiri-k nayiri-k commented Mar 9, 2023

Many updates to Sky130/Openroad Hammer flow.
Improvements to Sky130 Commercial/Openroad tutorial documentation.
Switched to Sram22 SRAMs.

Remaining TO DOs (add as needed):

  • update example-sky130.yml and example-designs files to eliminate redundant configs & have good floorplan/timing
  • bump versions of hammer & hammer vendor plugins
  • update changelog
  • either add conda installs of packages required for VLSI tutorial to CI flow or to tutorial flow

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

Copy link
Contributor

@harrisonliew harrisonliew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Chipyard's main README, can you add a link to the Hammer DAC paper like so:

H. Liew et al., DAC '22, pdf.

docs/VLSI/Sky130-Commercial-Tutorial.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SFTM. Didn't read the main part of the tutorial in-depth.

@@ -107,6 +107,61 @@ jobs:
source env.sh
cd sims/verilator
make verilog
- name: VLSI test
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abejgonzalez here is the VLSI tutorial flow, it currently passes CI but maybe it's a bit too hacky?

@abejgonzalez abejgonzalez merged commit 6149edb into main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants