Added UPF Support #775
Merged
Added UPF Support #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrisonliew
requested changes
Mar 30, 2023
There was a problem hiding this comment.
Thanks for this PR! A couple comments:
- It seems like these are UPF 2.0 commands. You might want to include a
upf_versioncommand in the header. Similarly, this comment may need to reflect that - Building on previous point, supporting UPF 3+ could be a switch? That option there could be like
upf_2.0orupf_3.1, etc. if you desire. - Is there any corresponding updates needed for the Cadence plugins?
hammer/vlsi/hammer_vlsi_impl.py
Outdated
| for g_net in ground_nets: | ||
| if(g_net.pin != None): | ||
| output.append("add_port_state {g} \\".format(g=g_net.name)) | ||
| output.append("\t-state {default off}") |
There was a problem hiding this comment.
I don't think this is correct according to my understanding of the command... instead it should be a voltage of 0. "off" is distinctly a different state?
There was a problem hiding this comment.
Was mistaken. Will fix that as soon as I get to it.
|
Really nitpicky here but could we switch to f-strings. Might just be nice to stick to for future code. |
|
@kenhoberkeley Added fstrings |
harrisonliew
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added UPF support to hammer. Generates a single power domain UPF. It should do exactly what hasCPFsupport does. Tested it by running PAR on the tapeout vlsi lab and manually feeding into innovus with the innovus command below:
read_power_intent -1801 power_spec.upf
power_spec.pdf
.
Related PRs / Issues
Type of change:
Impact:
Contributor Checklist:
masteras the base branch?poetry.lockfile if you updated the requirements inpyproject.toml?e2e/if this feature depends on updated plugins?