Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass ILM SDCs upwards through hierarchical flow #796

Merged
merged 4 commits into from
Sep 7, 2023
Merged

Conversation

harrisonliew
Copy link
Contributor

@harrisonliew harrisonliew commented Sep 7, 2023

ILM SDCs were not getting read during parent synthesis. These SDCs predominantly have set_case_analysis and set_annotated_transition commands, which are required in some cases to properly choose the proper timing mode in lib files.

Related PRs / Issues

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • Change to core Hammer
  • Change to a Hammer plugin
  • Other

Contributor Checklist:

  • Did you set master as the base branch?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you update the poetry.lock file if you updated the requirements in pyproject.toml?
  • (If applicable) Did you add a unit test demonstrating the PR?
  • (If applicable) Did you run this through the e2e integration tests?
  • (If applicable) Did you update the submodules in e2e/ if this feature depends on updated plugins?

@harrisonliew harrisonliew added bug hierarchical CurrentTapeout This issue is needed for an ongoing tapeout at UCB Cadence Specific to a Cadence tool labels Sep 7, 2023
Copy link

@SeahK SeahK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syn-ChipTop timing looks alright with this fix! Thanks :)

@harrisonliew harrisonliew added this pull request to the merge queue Sep 7, 2023
Merged via the queue into master with commit b1f970a Sep 7, 2023
3 checks passed
@harrisonliew harrisonliew deleted the ilm_sdc branch September 7, 2023 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Cadence Specific to a Cadence tool CurrentTapeout This issue is needed for an ongoing tapeout at UCB hierarchical
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants