Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tempfile.mkstemp instead of tempfile.NamedTemporaryFile for windows compatibility #732

Merged
merged 3 commits into from
Sep 9, 2023

Conversation

chrispyles
Copy link
Member

See #723 (comment)

FYI @ctnelson1997 this fix will be included in v5.1.4

@chrispyles chrispyles added the bug Something isn't working label Sep 9, 2023
@chrispyles chrispyles added this to the v5.1.4 milestone Sep 9, 2023
@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Patch coverage: 87.50% and project coverage change: -0.01% ⚠️

Comparison is base (4e3a882) 80.71% compared to head (f2fb1fd) 80.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #732      +/-   ##
==========================================
- Coverage   80.71%   80.71%   -0.01%     
==========================================
  Files          63       63              
  Lines        4206     4215       +9     
==========================================
+ Hits         3395     3402       +7     
- Misses        811      813       +2     
Files Changed Coverage Δ
otter/execute/preprocessor.py 86.08% <ø> (ø)
otter/execute/logging.py 93.22% <66.66%> (-3.08%) ⬇️
otter/execute/__init__.py 98.18% <92.85%> (+0.18%) ⬆️
otter/check/logs.py 82.53% <100.00%> (-0.10%) ⬇️
otter/run/run_autograder/__init__.py 85.48% <100.00%> (ø)
otter/test_files/__init__.py 76.21% <100.00%> (-0.15%) ⬇️
otter/utils.py 79.66% <100.00%> (+0.11%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrispyles chrispyles merged commit b54f4e2 into ucbds-infra:master Sep 9, 2023
3 checks passed
@chrispyles chrispyles deleted the fix-win-namedtempfile branch September 9, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

1 participant