Otter Grade Write Individual Notebook Results #826
Conversation
Pull Request Test Coverage Report for Build 10587753743Details
💛 - Coveralls |
test/test_grade/test_integration.py
Outdated
| if os.path.isfile(file_path): | ||
| assert os.path.exists(file_path) | ||
| with open(file_path, 'r') as file: | ||
| assert file.read() |
There was a problem hiding this comment.
Regardless of what's being written, this test should check that the contents are correct.
There was a problem hiding this comment.
Good deal -- checking the contents of summary files now
There was a problem hiding this comment.
I am not quite sure how you would mock this -- the summary files are written in grade/init.py main function. I am checking the files that are written to the disk. Maybe I am missing something here?
There was a problem hiding this comment.
Since the changes are in __init__.py, you can mock out the launch_containers function so it doesn't actually run but instead just returns some predetermined results. There's an example of this in test_config_overrides above (the mock is created with the @mock.patch(...) decorator and the return value is set by setting mocked_launch_grade.return_value.
There was a problem hiding this comment.
Ok, wait I am with you. Give me a second
There was a problem hiding this comment.
I rebased and forced the last commit to prevent another commit here.
I think I got it. Good deal
test/test_grade/test_integration.py
Outdated
| if os.path.isfile(file_path): | ||
| assert os.path.exists(file_path) | ||
| with open(file_path, 'r') as file: | ||
| assert file.read() |
|
@sean-morris PTAL at my comments above. I'd like to get v5.6.0 out this week if possible. Thanks |
|
I can get this in tomorrow. Thanks. School is just starting up so slow on
my end.
Sean
…On Sun, Aug 25, 2024 at 1:47 PM Chris Pyles ***@***.***> wrote:
@sean-morris <https://github.com/sean-morris> PTAL at my comments above.
I'd like to get v5.6.0 out this week if possible. Thanks
—
Reply to this email directly, view it on GitHub
<#826 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALR3446A22Q2HQB77UNXTLZTI7FLAVCNFSM6AAAAABMY3C632VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBYHE4DQMRXGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Addresses Issue #814: Otter Grade: Write out Individual Results as well as final_grades.csv