Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run nesting and the new physics using the global-workflow #4
base: nest
Are you sure you want to change the base?
Run nesting and the new physics using the global-workflow #4
Changes from 29 commits
d50754d
e3c85ff
a6ec298
7e7fe2c
c0208ef
c454e77
936e484
60d7d83
f89540c
5d51776
f8af477
cc7dcd6
85b12e7
1d83e88
e5315c9
91151af
4be24e5
eb4cfe2
023e510
d207862
2bedcf3
63447b3
273a08a
fd169d3
84c249c
7b2f01f
86de796
409543b
bbc0e55
dd37f80
469a63c
53da372
7c2dbaf
623c196
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have been left in as a
-f
command line option. Users should not edit the build scripts and uncomment things.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-f command line option can be easily passed into build_ufs.sh but it is hard to be passed into build_all.sh
We will consider a full workflow instead of only the forecast part.
Users need to modify build_ufs.sh anyway to include the global_nest_v1 physics in the compiling time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, it is best to use -DFASTER=ON as the default. It was designed to be both faster and safer than the defaults.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I trust you. But I am not sure whether EMC will accept a default -DFASTER=ON. But we can try.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The best option is to have -f in build_all.sh and have it passed down. If you don't want to do that, we should have it be -DFASTER=ON by default. Then EMC will tell us how to make it optional in the review.