-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add two regression tests to add benchmark regtest and wav-atm coupling test #61
Add two regression tests to add benchmark regtest and wav-atm coupling test #61
Conversation
Update datesuite tests to include 2013 tests update baseline area on hera
parm/input.mom6.nml.IN
Outdated
@@ -158,8 +158,8 @@ | |||
random_clds = .true. | |||
trans_trac = .false. | |||
cnvcld = .true. | |||
imfshalcnv = @[IMFSHALCNV] | |||
imfdeepcnv = @[IMFDEEPCNV] | |||
imfshalcnv = 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we probably want to keep imshalcnv and imfdeepcnv as settable parameters in the input.mom6.nml.IN.
In the benchmark.nml.IN they should remain fixed values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted. 2 is the default value in fv3.input so this should not effect any answers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Regtests are being re-run after last commit. Depending on how long the queues for hera are, should be done within an hour or so. Second reviewer has been added. |
The log files have been updated to confirm that the last change made no changes to answers. |
*Add RT results on Orion
This PR closes issues #31 and #46