Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two regression tests to add benchmark regtest and wav-atm coupling test #61

Merged
merged 25 commits into from
Mar 24, 2020

Conversation

JessicaMeixner-NOAA
Copy link
Collaborator

  • A 1 day regression test (1 day run and cold start) for the IC 2013040100 with the same physics/ICs/set-up as the benchmarks was added. 2013040100 was chosen as it frequently was the most unstable IC for previous bugs and will hopefully help us catch bugs in the future. This will help us know faster if an update will effect upcoming benchmark runs. (Issue Make 1 day reg test that matches a benchmark case #46)
  • Adds WAVEWATCH III as a component in the coupled model.
  • A 1 day regression tests (1 day run and cold start) for the IC 2013040100 that also has wav-atm two way coupling is added. It essentially mimics the above test plus wav-atm coupling. This test will be updated when wav-ocean coupling is added. (Issue create regression test for two-way wave-atm coupling for a FV3-MOM6-CICE5-WW3 test #31) Note this test also requires the removal of the option "norebuild" in compsets/nemscommon.input
  • A new baseline was created since the newest fv3atm Update EMC develop from NCAR dtc/develop 2020/03/17 NOAA-EMC/fv3atm#81 changes answers in the above two tests. Determining why these answers change will be taken up as part of Issue Analyze differences with updates for fractional grid for non-fractional case #39 which is still outstanding.
  • The date suite runs now have 4 more tests for 2013 cases (these are not run as part of the standard regression tests but can be turned on for quick-easy testing of 8 IC for stability testing).
  • Several app level files were updated to match the latest of the ufs-weather-model
  • Hera module file was updated to use post/8.0.6

This PR closes issues #31 and #46

@@ -158,8 +158,8 @@
random_clds = .true.
trans_trac = .false.
cnvcld = .true.
imfshalcnv = @[IMFSHALCNV]
imfdeepcnv = @[IMFDEEPCNV]
imfshalcnv = 2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we probably want to keep imshalcnv and imfdeepcnv as settable parameters in the input.mom6.nml.IN.
In the benchmark.nml.IN they should remain fixed values.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted. 2 is the default value in fv3.input so this should not effect any answers.

Copy link
Collaborator

@DeniseWorthen DeniseWorthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@JessicaMeixner-NOAA
Copy link
Collaborator Author

Regtests are being re-run after last commit. Depending on how long the queues for hera are, should be done within an hour or so. Second reviewer has been added.

@JessicaMeixner-NOAA
Copy link
Collaborator Author

The log files have been updated to confirm that the last change made no changes to answers.

@binli2337 binli2337 merged commit a59b6cf into ufs-community:develop Mar 24, 2020
MinsukJi-NOAA added a commit to MinsukJi-NOAA/ufs-s2s-model that referenced this pull request May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants