Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CICE, use -init=snan,arrays for Intel debug #935

Merged
merged 196 commits into from
Dec 15, 2021

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Nov 30, 2021

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

Updates CICE for the latest Consortium main. See CICE Issue #44 for a list of updates included. In particular, this PR will update the icepack submodule to include a fix which allows -init=snan,arrays to be used in debug mode.

The following change is required in ice_in:

index a91ed08d..77176455 100644
--- a/tests/parm/ice_in_template
+++ b/tests/parm/ice_in_template
@@ -105,7 +105,8 @@
     mu_rdg          = 3
     Cf              = 17.
     Ktens           = 0.
-    e_ratio         = 2.
+    e_yieldcurve    = 2.
+    e_plasticpot    = 2.
     coriolis        = 'latitude'
     kridge          = 1
     ktransport      = 1

Issue(s) addressed

Testing

On hera.intel at eb25340, all cpld and all datm_cdeps tests run to completion but fail comparison. This is due to a baseline-changing PR (round-off level) being brought in with the update to CICE-Consortium/main.

All other tests pass. All debug tests run to completion.

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

DeniseWorthen and others added 30 commits March 27, 2021 12:30
This reverts commit 7b826d4.
@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: cheyenne
Compiler: intel
Job: BL
Repo location: /glade/scratch/dtcufsrt/autort/tests/auto/pr/791172115/20211214104510/ufs-weather-model
Please manually delete: /glade/scratch/dtcufsrt/FV3_RT/rt_3814
Test fv3_esg_HAFS_v0_hwrf_thompson_debug 066 failed failed
Test fv3_esg_HAFS_v0_hwrf_thompson_debug 066 failed in run_test failed
Please make changes and add the following label back:
cheyenne-intel-BL

@DeniseWorthen
Copy link
Collaborator Author

The fv3_esg_HAFS_v0_hwrf_thompson_debug failure on Cheyenne.intel was a MPT:shepherd error. I tried copying the run directory and got the same failure. I'll try w/ a clean checkout and build.

@DeniseWorthen
Copy link
Collaborator Author

fv3_esg_HAFS_v0_hwrf_thompson_debug still fails with MPT:shepherd error on cheyenne.intel. My experience is this is usually a memory issue, so I tried setting more resources and the job did complete.

The only change that could be responsible for the failure is switching to -init=snan,arrays. I don't know anything about this test, or why the compile change would cause the job to fail.

@DeniseWorthen
Copy link
Collaborator Author

We're only missing Jet, which is on maintenance today. I'll start those when Jet returns tonight. We should be ready first thing for commit tomorrow morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. Waiting for Reviews The PR is waiting for reviews from associated component PR's.
Projects
None yet
6 participants