Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock Dockerfile.e2e base to stable python image #1474

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Conversation

currycoder
Copy link
Contributor

@currycoder currycoder commented Jun 15, 2023

Aim

Locks the Dockerfile.e2e to inherit from python:3.7-slim-bullseye - which uses a previous version of Debian in order to sidestep docker image build issues encountered as per; docker-library/python#837

@currycoder currycoder marked this pull request as ready for review June 15, 2023 12:26
Copy link
Contributor

@depsiatwal depsiatwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c640012) 58.92% compared to head (ec90ae0) 58.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##              uat    #1474   +/-   ##
=======================================
  Coverage   58.92%   58.92%           
=======================================
  Files         319      319           
  Lines       27676    27676           
  Branches     2181     2181           
=======================================
  Hits        16307    16307           
  Misses      10864    10864           
  Partials      505      505           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@currycoder currycoder merged commit f9358cf into uat Jun 15, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-e2e-docker branch June 15, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants