-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with incorrect language folder being copied #288
Comments
Hello @snowCho, |
Yep, this was probably unnecessary in the fix commit:
The reversed loop probably causes the default to be fetched before the current language, and all languages end up as the default 😮💨 There has to be a reason why it didn't happen when I tested it previously 🤔
EDIT: Investigating further, running the docs from #277 (comment) together with plugin version 1.2.1 it turned out that there is mixed behaviour.
and a incorrectly resolved path:
it's as if the |
Damn indeed I thought my current tests would catch that but they didn't :( sorry. @kamilkrzyskow should we revert and release 1.2.3 while a proper fix is found? |
This is completely my fault, I've written in #278 that there is still some issue lingering, but I ignored the gut feeling and didn't properly squash the issue, and in turn prevent this current issue. As for the release do as you like @ultrabug I won't be able to fix it today, should be possible tomorrow, I think that reverting releasing 1.2.2 and then releasing 1.2.3 with a fix is reasonable if deleting the pypi version isn't possible 🤔
EDIT: Correction |
I dropped the 1.2.1 from PyPI, seemed the fastest. We'll have to get correct tests up for the fix. |
Thank you for your quick reply. Let's guess the plugin version. |
@snowCho
this could perhaps explain some more about the issue 🤔 |
I ran the above command. (venv) goorm@SnowCho mkdocs % pip install git+https://github.com/kamilkrzyskow/i18n.git@fix/folder-with-tests After installation I built mkdocs and checked the fr folder. The en document is still in fr. |
No worries, @snowCho you're doing great. I saw that after installing the PR version you don't have the log messages, this showed me an error on my part as I limited the print output to only 2 specific paths 😓
Video of the built sitefirefox_tcVHAeebEE.mp4At the end I switched from French to English and the path used was Please provide more information as after you accessed
Then with the
Then with your own Korean
Those last commands should create log files you can attach to the message / drag & drop will work as well. |
@snowCho any progress on those log files? I would also like to ask you to make a |
@kamilkrzyskow |
@kamilkrzyskow Here it is. Thank you! goorm docs log |
I forgot to mention that the PR got a little fix, after I asked you for the logs 😓, but it doesn't matter in this scenario. I think there is in-fact a misunderstanding here. I worked with the assumption that the wrong directory is being copied over into the In your So try setting |
@kamilkrzyskow oh! The fallback_to_default: false option solved the problem. Thank you so much for your kind help! |
No problem, sorry it took so long, and for confusing you 😓I should know what you meant from the first post, but I started off with an assumption that there is some error in the code after my changes instead of the |
The contents of the mkdocs.yml file are as follows:
'''
site_name: 'Guide'
site_description: Documentation
docs_dir: docs/IDE/
extra_css:
theme:
name: material
features:
- content.tooltips
- navigation.tracking
- navigation.expand
- content.code.copy
- content.code.select
- content.code.annotate
- content.footnote.tooltips
extra:
social:
- icon: fontawesome/brands/github
link: site
- icon: fontawesome/brands/slack
link: site
tags:
:
generator: true
markdown_extensions:
custom_checkbox: true
anchor_linenums: true
line_spans: __span
pygments_lang_class: true
alternate_style: true
plugins:
docs_structure: folder
languages:
- locale: en
name: English
build: true
- locale: ko
name: Korean
build: true
default: true
- locale: ja
name: Japan
build: true`
The folder structure is as follows:
docs / ko / index.md
ko_folder / ko_index.md
en / index.md
en_folder / en_index.md
ja / index.md
ja_folder / ja_index.md
'''
When you do mkdocs build, the ko folder is copied to each of the en and ja folders in the site folder.
ex)
site / ko_index.md
a folder / ko_index.md
en / en_index.md
en_folder / en_index.md
ko_folder / ko_index.md
ja / index.md
ja_folder / ja_index.md
ko_folder / ko_index.md
What's the problem?
The text was updated successfully, but these errors were encountered: