Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NMS threshold checks #3020

Merged
merged 2 commits into from
May 3, 2021
Merged

Add NMS threshold checks #3020

merged 2 commits into from
May 3, 2021

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented May 3, 2021

PR asserts IoU and Confidence thresholds lie between 0.0 and 1.0.

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved input validation for non-maximum suppression in YOLOv5.

πŸ“Š Key Changes

  • Added checks to ensure the confidence threshold (conf_thres) and intersection over union threshold (iou_thres) are between 0.0 and 1.0.

🎯 Purpose & Impact

  • πŸ”’ Enhanced Robustness: Ensures the non-max suppression function only accepts valid threshold values, preventing potential errors or unexpected behavior during object detection.
  • βœ… Better User Guidance: Provides clear error messages if the user inputs invalid thresholds, making it easier for users to debug issues.
  • πŸ›  Code Reliability: These defensive programming checks contribute to overall code quality and reliability of the YOLOv5 framework.

@glenn-jocher glenn-jocher merged commit 41cc7ca into master May 3, 2021
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-5 branch May 3, 2021 13:07
KMint1819 pushed a commit to KMint1819/yolov5 that referenced this pull request May 12, 2021
* Add NMS threshold checks

* fix
danny-schwartz7 pushed a commit to danny-schwartz7/yolov5 that referenced this pull request May 22, 2021
* Add NMS threshold checks

* fix
Lechtr pushed a commit to Lechtr/yolov5 that referenced this pull request Jul 20, 2021
* Add NMS threshold checks

* fix

(cherry picked from commit 41cc7ca)
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
* Add NMS threshold checks

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant