Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI fire prep updates #7229

Merged
merged 2 commits into from
Mar 31, 2022
Merged

CLI fire prep updates #7229

merged 2 commits into from
Mar 31, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Mar 31, 2022

To prepare for possible CLI fire implementation in the future, i.e. #4981

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Refined argument printing for clarity and automation across various scripts.

πŸ“Š Key Changes

  • Replaced multiple instances of the print_args function call with a new unified version that automatically determines the caller's details.
  • Updated print_args logic to either automatically collect arguments from the previous frame or accept a manually provided dictionary of arguments.
  • Ensured file and function names are optionally included in the print_args output depending on flag settings.
  • Made sure the image size list is explicitly converted to a list even if initially given as a tuple, avoiding potential errors.

🎯 Purpose & Impact

  • The updated print_args function improves logging readability and helps in debugging by clearly indicating the origin of the logged arguments. πŸ“
  • Automatic collection of arguments reduces boilerplate and potential for manual errors when logging. πŸ› οΈ
  • The image size change ensures compatibility and reliability across different use cases, enhancing the robustness of the code. πŸ—οΈ
  • These changes will make life easier for developers working with the code and may provide users with clearer logs, contributing to a better understanding and troubleshooting experience. πŸ‘¨β€πŸ’»πŸ‘©β€πŸ’»

@glenn-jocher glenn-jocher self-assigned this Mar 31, 2022
@glenn-jocher glenn-jocher changed the title CLI fire prep updates CLI fire prep updates Mar 31, 2022
@glenn-jocher glenn-jocher merged commit 2c32218 into master Mar 31, 2022
@glenn-jocher glenn-jocher deleted the update/fire_prep branch March 31, 2022 15:11
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
* CLI fire prep updates

* revert unintentional TF export change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant