Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _make_grid() to model dtype #7346

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Apr 8, 2022

Per #6268 (comment)

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved tensor type consistency in YOLO grid creation.

πŸ“Š Key Changes

  • Ensured the tensors for creating grids match the data type of the associated anchors.
  • Modified the _make_grid function for better compatibility and efficiency.

🎯 Purpose & Impact

  • 🎯 Purpose: To maintain data type consistency throughout the model, which can prevent potential errors and ensure more predictable behavior.
  • πŸ’‘ Impact: Users may experience increased robustness and possibly a slight performance improvement during model training or inference, as well as better compatibility with different versions of PyTorch.

@glenn-jocher glenn-jocher self-assigned this Apr 8, 2022
@glenn-jocher glenn-jocher merged commit 302b00b into master Apr 8, 2022
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch April 8, 2022 10:55
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant