Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows check_file() fix #7938

Merged
merged 1 commit into from
May 23, 2022
Merged

Windows check_file() fix #7938

merged 1 commit into from
May 23, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented May 23, 2022

Resolves Ultralytics HUB CI errors.

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved URL handling in 'check_file' function.

πŸ“Š Key Changes

  • Removed the unnecessary conversion of URL using Path(), directly using file as URL.

🎯 Purpose & Impact

  • Ensures URLs are not inadvertently altered when checking for a local file, preserving the original URL formatting.
  • This fix prevents potential issues when downloading files from URLs, improving reliability for users downloading models or other files. πŸŒβœ…

Resolves Ultralytics HUB CI errors.
@glenn-jocher glenn-jocher self-assigned this May 23, 2022
@glenn-jocher glenn-jocher merged commit 541a5b7 into master May 23, 2022
@glenn-jocher glenn-jocher deleted the windows/check_file_fix branch May 23, 2022 14:15
tdhooghe pushed a commit to tdhooghe/yolov5 that referenced this pull request Jun 10, 2022
Resolves Ultralytics HUB CI errors.
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
Resolves Ultralytics HUB CI errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant