Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pip install wheel to avoid legacy setup.py install #8597

Merged
merged 3 commits into from
Jul 16, 2022
Merged

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Jul 16, 2022

Seeing these messages in linux CI which is confusing me.
Screen Shot 2022-07-16 at 4 16 20 PM

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Update to Python package installation process for better dependency management 🧱🔄

📊 Key Changes

  • wheel package is now installed alongside the latest pip when setting up environments.
  • Modifications affect Continuous Integration (CI) testing workflow and various Dockerfiles (default, ARM64, CPU).

🎯 Purpose & Impact

  • Purpose: Ensure smooth installation of dependencies and avoid potential issues with package builds. 🛠️
  • Impact: Users and developers who build YOLOv5 from source should experience more consistent and reliable installations, especially for complex packages that require compiling. Some CI processes might also run faster with these improvements. 🚀💻

@glenn-jocher
Copy link
Member Author

Problem solved! Expanding this to all other pip install code in YOLOv5.

@glenn-jocher glenn-jocher changed the title Update ci-testing with pip install wheel Add pip install wheel to avoid legacy setup.py install Jul 16, 2022
@glenn-jocher glenn-jocher merged commit 6e86af3 into master Jul 16, 2022
@glenn-jocher glenn-jocher deleted the update/ci branch July 16, 2022 14:41
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
…cs#8597)

* Update ci-testing with `pip install wheel`

* Update ci-testing.yml

* Update dockerfiles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant