Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove assert not is_docker() from GitHub checks #8813

Merged
merged 2 commits into from
Aug 1, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Aug 1, 2022

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved GitHub checks in non-Docker environments πŸ› οΈ.

πŸ“Š Key Changes

  • Removed the line that skips GitHub status checks if the code is running within a Docker image.

🎯 Purpose & Impact

  • Enables the GitHub status check feature within Docker containers, ensuring that users are alerted about updates even when operating in these environments.
  • Potentially affects users who rely on the Docker setup for YOLOv5, as they will now receive prompts for updates or changes to the repository, enhancing their awareness of new features or important fixes. πŸš€

@glenn-jocher glenn-jocher self-assigned this Aug 1, 2022
@glenn-jocher glenn-jocher merged commit 39ce8ca into master Aug 1, 2022
@glenn-jocher glenn-jocher deleted the update/github_nodockercheck branch August 1, 2022 01:01
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant