Support minimization and maximization of metrics #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rgemulla the metric.py file was not added, so I can't test this yet |
|
Added. |
rufex2001
reviewed
Sep 17, 2020
| def __init__(self, metric_max: Union[Job, Config, bool]): | ||
| "Params: metric_max=True means higher is better." | ||
| if isinstance(metric_max, Job): | ||
| metric_max = metric_max.config |
There was a problem hiding this comment.
Isn't the .get("valid.metric_max") missing here?
There was a problem hiding this comment.
The line right below does this.
rufex2001
reviewed
Sep 17, 2020
rufex2001
reviewed
Sep 17, 2020
|
Right! I automatically read those lines as mutually exclusive...
…On Thu, 17 Sep 2020, 23:13 Rainer Gemulla, ***@***.***> wrote:
Merged #147 <#147> into master.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#147 (comment)>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABEWXZDACUWNVQUMY4TSBCTSGJ3WDANCNFSM4RNS3OCQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
via a new config key
valid.metric_max@daniel: This is largely untested & I may also have missed some places where metrics are compared.