Several improvements for lookup_embedder.penalty #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apply embed also to embed_all use call to embeddings in penalty to make sparse embeddings work
samuelbroscheit
commented
May 14, 2020
samuelbroscheit
commented
May 14, 2020
rgemulla
reviewed
May 15, 2020
allocate all indexes dynamically
rgemulla
reviewed
May 20, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve memory uage for unweighted penalty by using PyTorch builtin norm()
use call to embeddings in penalty to make sparse embeddings work, before this fix unewighted penalty for sparse embeddings did not work