Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V10: Fix build warnings in core #12438

Merged
merged 119 commits into from
Jun 7, 2022
Merged

V10: Fix build warnings in core #12438

merged 119 commits into from
Jun 7, 2022

Conversation

Zeegaan
Copy link
Member

@Zeegaan Zeegaan commented May 20, 2022

Notes

Nikolaj Geisle added 6 commits May 6, 2022 10:15
Run code cleanup
2056e5d
Start manual cleanup after dotnet format
869c48b
Finish up manual pass
ffa487e
Fix up missed warnings
bb8763e
Merge remote-tracking branch 'origin/v10/dev' into v10/bugfix/fix-bui…
d399210 
…ld-warnings-in-Core

# Conflicts:
#	src/Umbraco.Core/Composing/ComponentComposer.cs
#	src/Umbraco.Core/Configuration/ConfigureConnectionStrings.cs
#	src/Umbraco.Core/Configuration/Models/ConnectionStrings.cs
#	src/Umbraco.Core/Constants-System.cs
#	src/Umbraco.Core/DependencyInjection/IUmbracoBuilder.cs
#	src/Umbraco.Core/DependencyInjection/UmbracoBuilder.CollectionBuilders.cs
#	src/Umbraco.Core/DependencyInjection/UmbracoBuilder.Collections.cs
#	src/Umbraco.Core/DependencyInjection/UmbracoBuilder.Configuration.cs
#	src/Umbraco.Core/DependencyInjection/UmbracoBuilder.cs
#	src/Umbraco.Core/Deploy/ArtifactBase.cs
#	src/Umbraco.Core/Deploy/ArtifactDeployState.cs
#	src/Umbraco.Core/Deploy/ArtifactDeployStateOfTArtifactTEntity.cs
#	src/Umbraco.Core/Deploy/IArtifactSignature.cs
#	src/Umbraco.Core/Deploy/IDataTypeConfigurationConnector.cs
#	src/Umbraco.Core/Deploy/IValueConnector.cs
#	src/Umbraco.Core/Extensions/ConnectionStringExtensions.cs
#	src/Umbraco.Core/Install/Models/UserModel.cs
#	src/Umbraco.Core/Models/ContentEditing/ContentItemDisplay.cs
#	src/Umbraco.Core/Models/Mapping/ContentVariantMapper.cs
#	src/Umbraco.Core/Models/Mapping/MemberTabsAndPropertiesMapper.cs
#	src/Umbraco.Core/Models/Membership/MemberExportModel.cs
#	src/Umbraco.Core/Persistence/Repositories/ITemplateRepository.cs
#	src/Umbraco.Core/Services/FileService.cs
#	src/Umbraco.Core/Services/IFileService.cs
#	src/Umbraco.Core/Services/ILocalizationService.cs
#	src/Umbraco.Core/Services/IMediaService.cs
#	src/Umbraco.Core/Services/IMemberService.cs
#	src/Umbraco.Core/Services/IMembershipRoleService.cs
#	src/Umbraco.Core/Services/LocalizationService.cs
#	src/Umbraco.Core/Services/MediaService.cs
#	src/Umbraco.Core/Services/MemberService.cs
#	src/Umbraco.Core/Services/MetricsConsentService.cs
Fix after merge
a6cea61
nikolajlauridsen
nikolajlauridsen reviewed May 30, 2022
View reviewed changes
Copy link
Contributor

@nikolajlauridsen nikolajlauridsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of findings :D

src/Umbraco.Core/Cache/ContentTypeCacheRefresher.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/Cache/DataTypeCacheRefresher.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/Cache/DeepCloneAppCache.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/Cache/DomainCacheRefresher.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/Cache/FastDictionaryAppCacheBase.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/Composing/WeightedCollectionBuilderBase.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/Configuration/Models/RequestHandlerSettings.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/ContentApps/ContentAppFactoryCollectionBuilder.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/Dashboards/DashboardCollectionBuilder.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/EmbeddedResources/Snippets/MultinodeTree-picker.cshtml Outdated Show resolved Hide resolved
nikolajlauridsen
nikolajlauridsen reviewed May 31, 2022
View reviewed changes
Copy link
Contributor

@nikolajlauridsen nikolajlauridsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another batch of files reviewed, only 800 to go 🎉

src/Umbraco.Core/Extensions/ContentExtensions.cs Show resolved Hide resolved
src/Umbraco.Core/Extensions/HostEnvironmentExtensions.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/Extensions/PublishedContentExtensions.cs Show resolved Hide resolved
src/Umbraco.Core/Extensions/StringExtensions.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/Extensions/StringExtensions.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/Models/PublishedContent/ModelType.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/Models/PublishedContent/PublishedContentBase.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/Models/PublishedContent/PublishedContentType.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/Models/PublishedContent/PublishedContentWrapped.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/Models/PublishedContent/PublishedPropertyType.cs Outdated Show resolved Hide resolved
nikolajlauridsen
nikolajlauridsen reviewed Jun 1, 2022
View reviewed changes
Copy link
Contributor

@nikolajlauridsen nikolajlauridsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another batch :D

src/Umbraco.Core/Notifications/ContentTypeRefreshedNotification.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/Notifications/ContentTypeSavedNotification.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/Notifications/ContentTypeSavingNotification.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/Notifications/ContentUnpublishingNotification.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/Notifications/DataTypeCacheRefresherNotification.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/Services/ITagService.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/Services/LocalizedTextServiceExtensions.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/Services/LocalizedTextServiceFileSources.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/Services/MediaService.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/Services/MemberService.cs Outdated Show resolved Hide resolved
nikolajlauridsen
nikolajlauridsen reviewed Jun 2, 2022
View reviewed changes
Copy link
Contributor

@nikolajlauridsen nikolajlauridsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the last ones :)

src/Umbraco.Core/Strings/DefaultShortStringHelper.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/Strings/UrlSegmentProviderCollectionBuilder.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/SystemLock.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/UriUtilityCore.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/UriUtilityCore.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/Web/IUmbracoContext.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/Web/IUmbracoContextAccessor.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/WebAssets/CustomBackOfficeAssetsCollectionBuilder.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/Xml/DynamicContext.cs Outdated Show resolved Hide resolved
src/Umbraco.Core/Xml/XPath/MacroNavigator.cs Outdated Show resolved Hide resolved
Zeegaan and others added 20 commits June 7, 2022 09:44
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Cache/ContentTypeCacheRefresher.cs
f86682c 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Cache/DataTypeCacheRefresher.cs
fdb6ed5 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Cache/DeepCloneAppCache.cs
8ac48ed 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Cache/DomainCacheRefresher.cs
e1e7667 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Cache/FastDictionaryAppCacheBase.cs
441c471 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Cache/FastDictionaryAppCacheBase.cs
bef747b 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Cache/FastDictionaryAppCacheBase.cs
c059af6 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Cache/FastDictionaryAppCacheBase.cs
1c93056 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Cache/FastDictionaryAppCacheBase.cs
6834c02 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Cache/MacroCacheRefresher.cs
dfc0bf8 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Cache/MediaCacheRefresher.cs
6e80faa 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Cache/MemberCacheRefresher.cs
f10dd03 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Cache/MemberGroupCacheRefresher.cs
1a4921c 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Composing/OrderedCollectionBuilderBase.cs
13f05bb 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Configuration/Models/RequestHandlerSettings.cs
e42fa7a 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Composing/SetCollectionBuilderBase.cs
36db366 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Composing/WeightedCollectionBuilderBase.cs
003d0c2 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/ContentApps/ContentAppFactoryCollectionBuilde…
6c5da5a 
…r.cs

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Dashboards/DashboardCollectionBuilder.cs
9239fc3 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Extensions/StringExtensions.cs
649431f 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Zeegaan and others added 27 commits June 7, 2022 10:15
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Install/InstallSteps/UpgradeStep.cs
78886ba 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Mapping/MapDefinitionCollectionBuilder.cs
b4c6cf5 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Media/EmbedProviders/EmbedProvidersCollection…
e540c44 
…Builder.cs

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Notifications/PartialViewSavedNotification.cs
cc3506a 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Models/ContentEditing/ContentVariationDisplay.cs
7480738 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Notifications/PartialViewSavingNotification.cs
d860a68 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Notifications/PublicAccessCacheRefresherNotif…
8a02257 
…ication.cs

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Notifications/PublicAccessEntryDeletedNotific…
8d23456 
…ation.cs

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Notifications/PublicAccessEntryDeletingNotifi…
8dbc4a3 
…cation.cs

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Notifications/PublicAccessEntryDeletingNotifi…
d4f26df 
…cation.cs

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Notifications/PublicAccessEntrySavedNotificat…
a594b64 
…ion.cs

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Notifications/PublicAccessEntrySavingNotifica…
9587d81 
…tion.cs

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Notifications/PublicAccessEntrySavingNotifica…
0173eab 
…tion.cs

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Notifications/RelationTypeCacheRefresherNotif…
8ed9460 
…ication.cs

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Notifications/RelationTypeDeletingNotificatio…
1414932 
…n.cs

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Notifications/RelationTypeSavedNotification.cs
cbe4c45 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Notifications/RelationTypeSavingNotification.cs
3c02be5 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Notifications/StatefulNotification.cs
650aeb0 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Notifications/StylesheetDeletingNotification.cs
92e196c 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Notifications/StylesheetSavingNotification.cs
78f831b 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Models/DeepCloneHelper.cs
c64688a 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Models/File.cs
85da9b9 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Models/PropertyGroupExtensions.cs
dfc23be 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan @nikolajlauridsen
Update src/Umbraco.Core/Models/PropertyGroupExtensions.cs
7531c3c 
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
@Zeegaan
Fix based on review
c4214ac
@Zeegaan
Merge remote-tracking branch 'origin/v10/dev' into v10/bugfix/fix-bui…
9687dfd 
…ld-warnings-in-Core

# Conflicts:
#	src/Umbraco.Core/Actions/ActionAssignDomain.cs
#	src/Umbraco.Core/Actions/ActionDelete.cs
#	src/Umbraco.Core/Configuration/ITypeFinderSettings.cs
#	src/Umbraco.Core/Configuration/Models/ActiveDirectorySettings.cs
#	src/Umbraco.Core/Configuration/Models/BasicAuthSettings.cs
#	src/Umbraco.Core/Constants-Configuration.cs
#	src/Umbraco.Core/DependencyInjection/ServiceCollectionExtensions.cs
#	src/Umbraco.Core/Routing/UrlProvider.cs
#	src/Umbraco.Core/Security/IBackofficeSecurity.cs
#	src/Umbraco.Core/Services/BasicAuthService.cs
#	src/Umbraco.Core/Services/ContentTypeServiceBaseOfTRepositoryTItemTService.cs
#	src/Umbraco.Core/Services/IBasicAuthService.cs
@Zeegaan
Fix after merge
f0e7547 
Signed-off-by: Zeegaan <nge@umbraco.dk>
@Zeegaan Zeegaan merged commit 60a5b19 into v10/dev Jun 7, 2022
@Zeegaan Zeegaan deleted the v10/bugfix/fix-build-warnings-in-Core branch June 7, 2022 13:28
@Zeegaan Zeegaan mentioned this pull request Oct 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikolajlauridsen nikolajlauridsen nikolajlauridsen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zeegaan @nikolajlauridsen