Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nucache rebuilding more type caches than necessary #12785

Merged

Conversation

nzdev
Copy link
Contributor

@nzdev nzdev commented Aug 5, 2022

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes

Description

Fix Nucache rebuilding more type caches than necessary. The Rebuild method is intended per it's existing docs to not rebuild the cache when the typeids are null, however this behavior has been broken. This results in slow cache rebuilds when rebuilding a limited number of types. For example Rebuild(new int[] {1234},null,null) results in cache rebuilds for content with content type 1234 having it's nucache rebuilt, as well as all media and members in the cache, which occurs if modifying content type 1234 via the backoffice ui and can be incredibly slow.

This pr fixes the issue by correcting the implementation of Rebuild, and adding a RebuildAll() to make it clearer to implementers how to rebuild all types vs a limited set of types.

@github-actions
Copy link

github-actions bot commented Aug 5, 2022

Hi there @nzdev, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@nul800sebastiaan nul800sebastiaan merged commit fdc1b02 into umbraco:v10/contrib Sep 8, 2022
@nul800sebastiaan nul800sebastiaan added category/performance Fixes for performance (generally cpu or memory) fixes type/bug release/10.3.0 community/pr labels Sep 8, 2022
@nul800sebastiaan
Copy link
Member

Thanks @nzdev - will ship with 10.3!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/performance Fixes for performance (generally cpu or memory) fixes community/pr release/10.3.0 type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants