Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship two json schema files.. One that reference others, and a CMS one #12858

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
94 commits
Select commit Hold shift + click to select a range
0794316
Ship two json schema files.. One that reference others, and a CMS one
bergmania Aug 18, 2022
f33b724
Content modal heading fix (#12797)
tiffy74 Aug 18, 2022
56e2829
Added copy functionality for data types (#11867)
patrickdemooij9 Aug 19, 2022
d6cd9a2
Ship two json schema files.. One that reference others, and a CMS one
bergmania Aug 18, 2022
e520434
Merge remote-tracking branch 'origin/v10/feature/read_json_schema_fro…
bergmania Aug 19, 2022
1024b26
Fix umb-range-slider merging overlapping tooltips (#12777)
bjarnef Aug 19, 2022
753cf35
Use umb-icon component in tracked references to support custom SVG ic…
bjarnef Aug 19, 2022
fa8bb3f
Fix #12770 (#12865)
MayurDeore Aug 22, 2022
523aa6c
V10 Fixup GitHub CodeSpaces / VSCode Remote Container (#12882)
Aug 23, 2022
38f144f
Merge branch 'v10/dev' into v10/contrib
nul800sebastiaan Aug 23, 2022
2431a21
V10/bugfix/variant permissions segments (#12890)
madsrasmussen Aug 24, 2022
0f3feb1
#12802 Fix partial view model type replacements (#12831)
mikaellindemann Aug 24, 2022
6242314
Update appsettings-schema: remove {Member,User}Password from Umbraco:CMS
PerplexDaniel Aug 24, 2022
b55f50c
Translate TreeHeaders to Spanish (#12902)
erikjanwestendorp Aug 26, 2022
47f77b6
Added support for disabling tabs in <umbTabsNav /> elements
abjerner Aug 7, 2022
68cf801
Replace uppercase chars to make behaviour consistent
bjarnef Aug 16, 2022
07fba1e
Revert "Break word for limited width content"
nul800sebastiaan Aug 30, 2022
fcd1c22
chore: Set permissions for GitHub actions
neilnaveen Jun 24, 2022
5f4f169
Translate 'settingsGroup' treeHeader to Spanish
erikjanwestendorp Aug 30, 2022
17d72f9
Update 01_bug_report.yml
nul800sebastiaan Sep 2, 2022
8f4d8d6
Use SVG logo in installer/upgrader (#12922)
bjarnef Sep 2, 2022
7bb5fbf
Translate languages area
erikjanwestendorp Sep 1, 2022
df3777f
Update add-issues-to-review-project.yml
sashashura Sep 2, 2022
1f5d58b
Fix: Media Picker creates duplicated folders (#12918) (#12948)
MayurDeore Sep 5, 2022
a0d6732
Translate content apps to spanish (#12950)
erikjanwestendorp Sep 6, 2022
5f42cf0
Revert "Replace uppercase chars to make behaviour consistent"
nul800sebastiaan Sep 8, 2022
fdc1b02
Fix Nucache rebuilding more type caches than necessary (#12785)
nzdev Sep 8, 2022
1bd0a1f
Set the first app to active if no active apps
matthewcare Sep 3, 2022
4df012e
Skip move logic if the parent is staying the same (#12937)
CyberReiter Sep 9, 2022
902f126
Added support for virtual backoffice icons (#12833)
abjerner Sep 9, 2022
09e2b04
V10: Update examine dependency (#12982)
Zeegaan Sep 12, 2022
a356cf4
Backoffice api: Refactor controllers (#12934)
nikolajlauridsen Sep 13, 2022
e9883ea
Add custom PrependBasePathFileProvider to handle media files with spe…
kjac Sep 13, 2022
b84ccea
Add label-key to prevent cleanup button (#12990)
erikjanwestendorp Sep 14, 2022
6d27454
Added nullable helper for IfNullOrWhiteSpace (#12979)
patrickdemooij9 Sep 15, 2022
eddf0ad
Only show table when any filtered result (#12993)
bjarnef Sep 16, 2022
ad1c945
update npm packages
iOvergaard Sep 16, 2022
6298fb3
Merge pull request #13014 from umbraco/v10/feature/september-dep-updates
nikolajlauridsen Sep 16, 2022
6967fad
pass in parameters needed to member service (#13020)
Bakersbakebread Sep 17, 2022
6f9bf59
fix: focus state for search and help icons
MMasey Sep 17, 2022
51f7beb
Ship two json schema files.. One that reference others, and a CMS one
bergmania Aug 18, 2022
63052dc
Merge remote-tracking branch 'origin/v10/feature/read_json_schema_fro…
bergmania Sep 19, 2022
0b1295d
Missing methods from IMemberService (#13022)
Zeegaan Sep 19, 2022
d18dc92
V10: Fix to allow dragged images in the rich text editor to be correc…
iOvergaard Sep 19, 2022
c1010e5
Merge remote-tracking branch 'origin/v10/dev' into v11/dev
bergmania Sep 19, 2022
ef15da3
Bypass model validation for rendering models (#12999)
kjac Sep 19, 2022
803c044
Updated dependencies and fixed new NRT issues
bergmania Sep 19, 2022
40df989
Merge remote-tracking branch 'origin/v11/dev' into v11/dev
bergmania Sep 19, 2022
8de26c6
Revert "Merge remote-tracking branch 'origin/v11/dev' into v11/dev"
iOvergaard Sep 19, 2022
1ddfcba
Updated more dependencies
bergmania Sep 19, 2022
87c06f5
Back to 10.2.0-ish
nul800sebastiaan Sep 19, 2022
48bd4a5
Grammar (do -> does) and some extra text
nul800sebastiaan Aug 29, 2022
31dc7fa
Fix #12770 (#12865)
MayurDeore Aug 22, 2022
6302630
Revert "Break word for limited width content"
nul800sebastiaan Aug 30, 2022
147c60f
Performance improvement: Reusable data editors (#12921)
kjac Aug 31, 2022
6b967a9
Add virtual SetUpTestConfiguration method (#12928)
Zeegaan Aug 31, 2022
126a259
remove styling from installer (#12923)
iOvergaard Aug 31, 2022
669f8ff
Backoffice Api: Server Controller (#12932)
nikolajlauridsen Sep 1, 2022
7852220
Use staticserviceprovider to provide service (#12939)
Zeegaan Sep 2, 2022
5500f87
Limit what API does when not in used in Install level
bergmania Sep 5, 2022
7d0be19
Add PagedViewModel (#12955)
Zeegaan Sep 6, 2022
3ab57ce
Bump version
nikolajlauridsen Sep 7, 2022
0a77775
Fixed InstallAuthorizeAttribute and simplified other things
bergmania Sep 7, 2022
aa7a7c4
Fix tree root font being larger than it used to be
nul800sebastiaan Sep 7, 2022
48c981d
Hotfix: Move allow edit invariant from non default setting to content…
nikolajlauridsen Sep 7, 2022
0c84b1a
Extend error message with possible solution (#12962)
Zeegaan Sep 7, 2022
788f8c6
Undo breaking change
nikolajlauridsen Sep 7, 2022
79c6733
Ensure new projects use the correct apssettings key for AllowEditInva…
nikolajlauridsen Sep 8, 2022
352da6c
V10: Update examine dependency (#12982)
Zeegaan Sep 12, 2022
22576ed
Backoffice api: Refactor controllers (#12934)
nikolajlauridsen Sep 13, 2022
07b7ef2
Add custom PrependBasePathFileProvider to handle media files with spe…
kjac Sep 13, 2022
963d001
update npm packages
iOvergaard Sep 16, 2022
1fe4c51
V10: Fix to allow dragged images in the rich text editor to be correc…
iOvergaard Sep 19, 2022
b2b2903
Updated dependencies and fixed new NRT issues
bergmania Sep 19, 2022
85147fb
Merge branch 'v10/dev' into v11/dev
nul800sebastiaan Sep 19, 2022
db5d05d
Revert files that shouldn't change back in v11
nul800sebastiaan Sep 19, 2022
85e31bd
Merge branch 'v10/dev' into v10/contrib
nul800sebastiaan Sep 19, 2022
8d5fb41
Revert "Updated dependencies and fixed new NRT issues"
nul800sebastiaan Sep 20, 2022
40035aa
Merge branch 'v10/dev' into v11/dev
nul800sebastiaan Sep 20, 2022
48954bb
New Backoffice - Exposing hardcoded Open API contract (#12953)
bergmania Sep 20, 2022
954d3ec
v10: add Umbraco UI Library to the backoffice (#13031)
iOvergaard Sep 20, 2022
d139f4a
Updated dependencies and fixed new NRT issues
bergmania Sep 19, 2022
42c32e7
Merge branch 'v10/dev' into v11/dev
nul800sebastiaan Sep 20, 2022
0841531
Fix merge conflict
nul800sebastiaan Sep 20, 2022
510d8bf
V11: Update the rich text editor TinyMCE to v6 (#13013)
iOvergaard Sep 20, 2022
d206df0
Updated dependencies and cleaned up
bergmania Sep 23, 2022
3873a07
v11: Decouple dependencies (#12907)
ronaldbarendse Sep 27, 2022
7963b76
Adds additional deploy selector. (#13094)
AndyButland Oct 3, 2022
c9f6d60
Add GitVersionBaseDirectory and fix typo
ronaldbarendse Oct 3, 2022
ad39041
Ship two json schema files.. One that reference others, and a CMS one
bergmania Aug 18, 2022
dbc985c
Ship two json schema files.. One that reference others, and a CMS one
bergmania Aug 18, 2022
c34578b
Ship two json schema files.. One that reference others, and a CMS one
bergmania Aug 18, 2022
2ee9ad1
git ignore
bergmania Oct 5, 2022
94a06eb
Merge remote-tracking branch 'origin/v10/feature/read_json_schema_fro…
bergmania Oct 5, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 9 additions & 30 deletions .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,36 +1,15 @@
# [Choice] .NET Core version: 5.0, 3.1, 2.1
ARG VARIANT=3.1
FROM mcr.microsoft.com/vscode/devcontainers/dotnetcore:0-${VARIANT}
# [Choice] .NET version: 6.0, 3.1, 6.0-bullseye, 3.1-bullseye, 6.0-focal, 3.1-focal
ARG VARIANT=6.0-bullseye
FROM mcr.microsoft.com/vscode/devcontainers/dotnet:0-${VARIANT}

# [Option] Install Node.js
ARG INSTALL_NODE="true"
ARG NODE_VERSION="lts/*"
RUN if [ "${INSTALL_NODE}" = "true" ]; then su vscode -c "umask 0002 && . /usr/local/share/nvm/nvm.sh && nvm install ${NODE_VERSION} 2>&1"; fi

# [Option] Install Azure CLI
ARG INSTALL_AZURE_CLI="false"
COPY library-scripts/azcli-debian.sh /tmp/library-scripts/
RUN if [ "$INSTALL_AZURE_CLI" = "true" ]; then bash /tmp/library-scripts/azcli-debian.sh; fi \
&& apt-get clean -y && rm -rf /var/lib/apt/lists/* /tmp/library-scripts

# Install SQL Tools: SQLPackage and sqlcmd
COPY mssql/installSQLtools.sh installSQLtools.sh
RUN bash ./installSQLtools.sh \
&& apt-get clean -y && rm -rf /var/lib/apt/lists/* /tmp/library-scripts

# Update args in docker-compose.yaml to set the UID/GID of the "vscode" user.
ARG USER_UID=1000
ARG USER_GID=$USER_UID
RUN if [ "$USER_GID" != "1000" ] || [ "$USER_UID" != "1000" ]; then groupmod --gid $USER_GID vscode && usermod --uid $USER_UID --gid $USER_GID vscode; fi
# [Choice] Node.js version: none, lts/*, 18, 16, 14
ARG NODE_VERSION="none"
RUN if [ "${NODE_VERSION}" != "none" ]; then su vscode -c "umask 0002 && . /usr/local/share/nvm/nvm.sh && nvm install ${NODE_VERSION} 2>&1"; fi


# [Optional] Uncomment this section to install additional OS packages.
# Following added by Warren...
# Needed to add as Gifsicle used by gulp-imagemin does not ship a Linux binary and has to be compiled from source
# And this Linux package is needed in order to build it
# https://github.com/imagemin/imagemin-gifsicle/issues/40#issuecomment-616487214
RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \
&& apt-get -y install --no-install-recommends dh-autoreconf chromium-browser
# RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \
# && apt-get -y install --no-install-recommends <your-package-list-here>

# [Optional] Uncomment this line to install global node packages.
# RUN su vscode -c "source /usr/local/share/nvm/nvm.sh && npm install -g <your-package-here>" 2>&1
Expand All @@ -42,7 +21,7 @@ RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \
# Needing to set unsafe-perm as root is the user setup
# https://docs.npmjs.com/cli/v6/using-npm/config#unsafe-perm
# Default: false if running as root, true otherwise (we are ROOT)
RUN npm -g config set user vscode && npm -g config set unsafe-perm
#RUN npm -g config set user vscode && npm -g config set unsafe-perm

# Generate and trust a local developer certificate for Kestrel
# This is needed for Kestrel to bind on https
Expand Down
30 changes: 6 additions & 24 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -1,41 +1,25 @@
// For format details, see https://aka.ms/devcontainer.json. For config options, see the README at:
// https://github.com/microsoft/vscode-dev-containers/tree/v0.158.0/containers/dotnet-mssql
// https://github.com/microsoft/vscode-dev-containers/tree/main/containers/dotnet
{
"name": "C# (.NET) and MS SQL",
"name": "C# (.NET) Umbraco & SMTP4Dev",
"dockerComposeFile": "docker-compose.yml",
"service": "app",
"workspaceFolder": "/workspace",

// Set *default* container specific settings.json values on container create.
"settings": {
"terminal.integrated.shell.linux": "/bin/bash",
"mssql.connections": [
{
"server": "localhost,1433",
"database": "",
"authenticationType": "SqlLogin",
"user": "sa",
"password": "P@ssw0rd",
"emptyPasswordInput": false,
"savePassword": false,
"profileName": "mssql-container"
}
],
"settings": {
"omnisharp.defaultLaunchSolution": "umbraco.sln",
"omnisharp.enableDecompilationSupport": true,
"omnisharp.enableRoslynAnalyzers": true
},

// Add the IDs of extensions you want installed when the container is created.
"extensions": [
"ms-dotnettools.csharp",
"ms-mssql.mssql"
"ms-dotnettools.csharp"
],

// Use 'forwardPorts' to make a list of ports inside the container available locally.
// 1433 for SQL if you want to connect from local into the one running inside the container
// Can connect to the SQL Server running in the image on local with 'host.docker.internal' as hostname
"forwardPorts": [1433, 9000, 5000, 25],
"forwardPorts": [9000, 5000, 25]

// [Optional] To reuse of your local HTTPS dev cert:
//
Expand All @@ -56,6 +40,4 @@
// 2. Drag ~/.aspnet/https/aspnetapp.pfx into the root of the file explorer
// 3. Open a terminal in VS Code and run "mkdir -p /home/vscode/.aspnet/https && mv aspnetapp.pfx /home/vscode/.aspnet/https"

// postCreateCommand.sh parameters: $1=SA password, $2=dacpac path, $3=sql script(s) path
"postCreateCommand": "bash .devcontainer/mssql/postCreateCommand.sh 'P@ssw0rd' './bin/Debug/' './.devcontainer/mssql/'"
}
25 changes: 4 additions & 21 deletions .devcontainer/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,25 +6,17 @@ services:
context: .
dockerfile: Dockerfile
args:
# [Choice] Update 'VARIANT' to pick a .NET Core version: 2.1, 3.1, 5.0
VARIANT: 5.0
# [Choice] .NET version: 6.0, 3.1, 6.0-bullseye, 3.1-bullseye, 6.0-focal, 3.1-focal
VARIANT: 6.0-bullseye
# Options
INSTALL_NODE: "true"
NODE_VERSION: "lts/*"
INSTALL_AZURE_CLI: "false"
# On Linux, you may need to update USER_UID and USER_GID below if not your local UID is not 1000.
USER_UID: 1000
USER_GID: 1000

volumes:
- ..:/workspace:cached

# Overrides default command so things don't shut down after the process ends.
command: sleep infinity

# Runs app on the same network as the database container, allows "forwardPorts" in devcontainer.json function.
network_mode: service:db

# Uncomment the next line to use a non-root user for all processes.
# user: vscode

Expand All @@ -34,7 +26,8 @@ services:
# DotNetCore ENV Variables
# https://docs.microsoft.com/en-us/aspnet/core/fundamentals/configuration/?view=aspnetcore-5.0#environment-variables
environment:
- ConnectionStrings__umbracoDbDSN=server=localhost;database=UmbracoUnicore;user id=sa;password='P@ssw0rd'
- ConnectionStrings__umbracoDbDSN=Data Source=|DataDirectory|/Umbraco.sqlite.db;Cache=Shared;Foreign Keys=True;Pooling=True
- ConnectionStrings__umbracoDbDSN_ProviderName=Microsoft.Data.Sqlite
- Umbraco__CMS__Unattended__InstallUnattended=true
- Umbraco__CMS__Unattended__UnattendedUserName=Admin
- Umbraco__CMS__Unattended__UnattendedUserEmail=test@umbraco.com
Expand All @@ -43,16 +36,6 @@ services:
- Umbraco__CMS__Global__Smtp__Port=25
- Umbraco__CMS__Global__Smtp__From=noreply@umbraco.test

db:
image: mcr.microsoft.com/mssql/server:2019-latest
restart: unless-stopped
environment:
SA_PASSWORD: P@ssw0rd
ACCEPT_EULA: Y

# Add "forwardPorts": ["1433"] to **devcontainer.json** to forward MSSQL locally.
# (Adding the "ports" property to this file will not forward from a Codespace.)

smtp4dev:
image: rnwood/smtp4dev:v3
restart: always
Expand Down
33 changes: 0 additions & 33 deletions .devcontainer/library-scripts/azcli-debian.sh

This file was deleted.

11 changes: 0 additions & 11 deletions .devcontainer/mssql/BlankDb.sql

This file was deleted.

16 changes: 0 additions & 16 deletions .devcontainer/mssql/installSQLtools.sh

This file was deleted.

64 changes: 0 additions & 64 deletions .devcontainer/mssql/postCreateCommand.sh

This file was deleted.

2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/01_bug_report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ body:
- type: input
id: "version"
attributes:
label: "Which *exact* Umbraco version are you using? For example: 9.0.1 - don't just write v9"
label: "Which Umbraco version are you using? (Please write the *exact* version, example: 10.1.0)"
description: "Use the help icon in the Umbraco backoffice to find the version you're using"
validations:
required: true
Expand Down
8 changes: 4 additions & 4 deletions .github/New BackOffice - README.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
# New Backoffice
# New backoffice

> **Warning**:
> This is an early WIP, and is set not to be packable since we don't want to release this yet. There will be breaking changes in these projects
> This is an early WIP and is set not to be packable since we don't want to release this yet. There will be breaking changes in these projects.

This solution folder contains the projects for the new BackOffice. If you're looking to fix or improve the existing CMS, this is not the place to do it, although we do very much appreciate your efforts.
This solution folder contains the projects for the new backoffice. If you're looking to fix or improve the existing CMS, this is not the place to do it, although we do very much appreciate your efforts.

### Project structure

Since the new backoffice API is still very much a work in progress we've created new projects for the new backoffice API:
Since the new backoffice API is still very much a work in progress, we've created new projects for the new backoffice API:

* Umbrao.Cms.ManagementApi - The "presentation layer" for the management API
* "New" versions of existing projects, should be merged with the existing projects when the new API is released:
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/add-issues-to-review-project.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ on:
types:
- opened

permissions:
contents: read

jobs:
get-user-type:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -43,6 +46,8 @@ jobs:
core.setOutput("ignored", isIgnoredUser);
console.log("Ignored is", isIgnoredUser);
add-to-project:
permissions:
repository-projects: write # for actions/add-to-project
if: needs.get-user-type.outputs.ignored == 'false'
runs-on: ubuntu-latest
needs: [get-user-type]
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,16 @@ on:
# The branches below must be a subset of the branches above
branches: ['*/dev','*/contrib']

permissions:
contents: read

jobs:
CodeQL-Build:

permissions:
actions: read # for github/codeql-action/init to get workflow details
contents: read # for actions/checkout to fetch code
security-events: write # for github/codeql-action/analyze to upload SARIF results
runs-on: ubuntu-latest
permissions:
actions: read
Expand Down
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -104,5 +104,9 @@ cypress.env.json
/tests/Umbraco.Tests.UnitTests/[Uu]mbraco/[Dd]ata/TEMP/

# Ignore auto-generated schema
/src/Umbraco.Cms.Targets/appsettings-schema.json
/src/Umbraco.Web.UI/appsettings-schema.json
/src/Umbraco.Web.UI/appsettings-schema.umbraco.json
/tests/Umbraco.Tests.Integration/appsettings-schema.json
/src/Umbraco.Cms/appsettings-schema.json
/src/Umbraco.Cms/appsettings-schema.umbraco.json
5 changes: 2 additions & 3 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,8 @@
"type": "coreclr",
"request": "launch",
"preLaunchTask": "Dotnet build",
// If you have changed target frameworks, make sure to update the program path.
"program": "${workspaceFolder}/src/Umbraco.Web.UI/bin/Debug/net5.0/Umbraco.Web.UI.dll",
"args": [],
"program": "dotnet",
"args": ["run"],
"cwd": "${workspaceFolder}/src/Umbraco.Web.UI",
"stopAtEntry": false,
"requireExactSource": false,
Expand Down
3 changes: 2 additions & 1 deletion .vscode/tasks.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"type": "process",
"args": [
"build",
"${workspaceFolder}/src/umbraco.sln",
"${workspaceFolder}/umbraco.sln",
"/property:GenerateFullPaths=true",
"/consoleloggerparameters:NoSummary"
],
Expand All @@ -69,6 +69,7 @@
"args": [
"watch",
"run",
"--project",
"${workspaceFolder}/src/Umbraco.Web.UI/Umbraco.Web.UI.csproj",
"/property:GenerateFullPaths=true",
"/consoleloggerparameters:NoSummary"
Expand Down
Loading