-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new 'Umbraco Package RCL' project template #13460
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,9 +41,16 @@ | |
"description": "The version of Umbraco.Cms to add as PackageReference.", | ||
"type": "parameter", | ||
"datatype": "string", | ||
"defaultValue": "10.0.0-rc1", | ||
"defaultValue": "11.0.0", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This value is automatically updated in the Azure Pipelines build script (causing the generated NuGet package to always contain the same Umbraco version number as itself), but we might want to update the source to at least the latest major version or otherwise a more generic |
||
"replaces": "UMBRACO_VERSION_FROM_TEMPLATE" | ||
}, | ||
"SkipRestore": { | ||
"displayName": "Skip restore", | ||
"description": "If specified, skips the automatic restore of the project on create.", | ||
"type": "parameter", | ||
"datatype": "bool", | ||
"defaultValue": "false" | ||
}, | ||
"Namespace": { | ||
"type": "derived", | ||
"valueSource": "name", | ||
|
@@ -83,5 +90,19 @@ | |
{ | ||
"path": "UmbracoPackage.csproj" | ||
} | ||
], | ||
"postActions": [ | ||
{ | ||
"id": "restore", | ||
"condition": "(!SkipRestore)", | ||
"description": "Restore NuGet packages required by this project.", | ||
"manualInstructions": [ | ||
{ | ||
"text": "Run 'dotnet restore'" | ||
} | ||
], | ||
"actionId": "210D431B-A78B-4D2F-B762-4ED3E3EA9025", | ||
"continueOnError": true | ||
} | ||
] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
{ | ||
"$schema": "https://json.schemastore.org/dotnetcli.host.json", | ||
"symbolInfo": { | ||
"Framework": { | ||
"longName": "framework", | ||
"isHidden": true | ||
}, | ||
"UmbracoVersion": { | ||
"longName": "version", | ||
"shortName": "" | ||
}, | ||
"SkipRestore": { | ||
"longName": "no-restore", | ||
"shortName": "" | ||
}, | ||
"SupportPagesAndViews": { | ||
"longName": "support-pages-and-views", | ||
"shortName": "s" | ||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
{ | ||
"$schema": "https://json.schemastore.org/ide.host.json", | ||
"order": 0, | ||
"icon": "../../icon.png", | ||
"description": { | ||
"id": "UmbracoPackageRcl", | ||
"text": "Umbraco Package RCL - An empty Umbraco package/plugin (Razor Class Library)." | ||
}, | ||
"symbolInfo": [ | ||
{ | ||
"id": "UmbracoVersion", | ||
"isVisible": true | ||
}, | ||
{ | ||
"id": "SupportPagesAndViews", | ||
"isVisible": true, | ||
"persistenceScope": "templateGroup" | ||
} | ||
] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
{ | ||
"$schema": "https://json.schemastore.org/template.json", | ||
"author": "Umbraco HQ", | ||
"classifications": [ | ||
"Web", | ||
"CMS", | ||
"Umbraco", | ||
"Package", | ||
"Plugin", | ||
"Razor Class Library" | ||
], | ||
"name": "Umbraco Package RCL", | ||
"description": "An empty Umbraco package/plugin (Razor Class Library).", | ||
"groupIdentity": "Umbraco.Templates.UmbracoPackageRcl", | ||
"identity": "Umbraco.Templates.UmbracoPackageRcl.CSharp", | ||
"shortName": "umbracopackage-rcl", | ||
"tags": { | ||
"language": "C#", | ||
"type": "project" | ||
}, | ||
"sourceName": "UmbracoPackage", | ||
"defaultName": "UmbracoPackage1", | ||
"preferNameDirectory": true, | ||
"symbols": { | ||
"Framework": { | ||
"displayName": "Framework", | ||
"description": "The target framework for the project.", | ||
"type": "parameter", | ||
"datatype": "choice", | ||
"choices": [ | ||
{ | ||
"displayName": ".NET 7.0", | ||
"description": "Target net7.0", | ||
"choice": "net7.0" | ||
} | ||
], | ||
"defaultValue": "net7.0", | ||
"replaces": "net7.0" | ||
}, | ||
"UmbracoVersion": { | ||
"displayName": "Umbraco version", | ||
"description": "The version of Umbraco.Cms to add as PackageReference.", | ||
"type": "parameter", | ||
"datatype": "string", | ||
"defaultValue": "11.0.0", | ||
"replaces": "UMBRACO_VERSION_FROM_TEMPLATE" | ||
}, | ||
"SkipRestore": { | ||
"displayName": "Skip restore", | ||
"description": "If specified, skips the automatic restore of the project on create.", | ||
"type": "parameter", | ||
"datatype": "bool", | ||
"defaultValue": "false" | ||
}, | ||
"SupportPagesAndViews": { | ||
"type": "parameter", | ||
"datatype": "bool", | ||
"defaultValue": "false", | ||
"displayName": "Support pages and views", | ||
"description": "Whether to support adding traditional Razor pages and Views to this library." | ||
} | ||
}, | ||
"primaryOutputs": [ | ||
{ | ||
"path": "UmbracoPackage.csproj" | ||
} | ||
], | ||
"postActions": [ | ||
{ | ||
"id": "restore", | ||
"condition": "(!SkipRestore)", | ||
"description": "Restore NuGet packages required by this project.", | ||
"manualInstructions": [ | ||
{ | ||
"text": "Run 'dotnet restore'" | ||
} | ||
], | ||
"actionId": "210D431B-A78B-4D2F-B762-4ED3E3EA9025", | ||
"continueOnError": true | ||
} | ||
] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
<Project Sdk="Microsoft.NET.Sdk.Razor"> | ||
<PropertyGroup> | ||
<TargetFramework>net7.0</TargetFramework> | ||
<Nullable>enable</Nullable> | ||
<ImplicitUsings>enable</ImplicitUsings> | ||
<AddRazorSupportForMvc Condition="'$(SupportPagesAndViews)' == 'True'">true</AddRazorSupportForMvc> | ||
<RootNamespace Condition="'$(name)' != '$(name{-VALUE-FORMS-}safe_namespace)'">UmbracoPackage</RootNamespace> | ||
<StaticWebAssetBasePath>App_Plugins/UmbracoPackage</StaticWebAssetBasePath> | ||
</PropertyGroup> | ||
|
||
<PropertyGroup> | ||
<PackageId>UmbracoPackage</PackageId> | ||
<Product>UmbracoPackage</Product> | ||
<Title>UmbracoPackage</Title> | ||
<Description>...</Description> | ||
<PackageTags>umbraco plugin package</PackageTags> | ||
</PropertyGroup> | ||
|
||
<ItemGroup Condition="'$(SupportPagesAndViews)' == 'True'"> | ||
<FrameworkReference Include="Microsoft.AspNetCore.App" /> | ||
</ItemGroup> | ||
|
||
<ItemGroup> | ||
<PackageReference Include="Umbraco.Cms.Web.Website" Version="UMBRACO_VERSION_FROM_TEMPLATE" /> | ||
<PackageReference Include="Umbraco.Cms.Web.BackOffice" Version="UMBRACO_VERSION_FROM_TEMPLATE" /> | ||
</ItemGroup> | ||
</Project> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"name": "UmbracoPackage", | ||
"version": "", | ||
"allowPackageTelemetry": true | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,19 +13,18 @@ | |
}, | ||
{ | ||
"id": "UseHttpsRedirect", | ||
"isVisible": true | ||
}, | ||
{ | ||
"id": "SkipRestore", | ||
"isVisible": true | ||
"isVisible": true, | ||
"persistenceScope": "templateGroup" | ||
}, | ||
{ | ||
"id": "ExcludeGitignore", | ||
"isVisible": true | ||
"isVisible": true, | ||
"persistenceScope": "templateGroup" | ||
}, | ||
{ | ||
"id": "MinimalGitignore", | ||
"isVisible": true | ||
"isVisible": true, | ||
"persistenceScope": "templateGroup" | ||
}, | ||
{ | ||
"id": "ConnectionString", | ||
|
@@ -37,7 +36,8 @@ | |
}, | ||
{ | ||
"id": "DevelopmentDatabaseType", | ||
"isVisible": true | ||
"isVisible": true, | ||
"persistenceScope": "templateGroup" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding this |
||
}, | ||
{ | ||
"id": "UnattendedUserName", | ||
|
@@ -54,10 +54,6 @@ | |
{ | ||
"id": "NoNodesViewPath", | ||
"isVisible": true | ||
}, | ||
{ | ||
"id": "PackageProjectName", | ||
"isVisible": true | ||
} | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only allowed framework version is
net7.0
, so there's no need to show this parameter.Since this value isn't supported on older Umbraco versions, any unaltered command would result in an
...is not a valid value...
error, so I've also updated the capitalization to align with the default ASP.NET Core templates.