Only add global usings when ImplicitUsings is enabled #13491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
nikolajlauridsen
added a commit
that referenced
this pull request
Dec 1, 2022
* update marketplace url to its final, live url * Added various Block Grid translations (EN & NL) (#13488) * Added various translations * Added another translation * Change request * Revert breaking changes adding IContextCache to deploy connectors (#13489) * Remove breaking changes in Deploy connector interfaces * Add extension methods for calling the new interface methods in a backwards-compatible way * Create and pack empty file to add TFM dependency (#13475) * Change login image to new SVG. (#13493) * Only add global usings when ImplicitUsings is enabled (#13491) * bump to rc6 * V11: Allow changing logging directory from configuration (#13485) * Allow changing logging directory from configuration * Clean up * Missing return statement * Apply suggestions from code review Co-authored-by: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com> * Update src/Umbraco.Core/Constants-SystemDirectories.cs Co-authored-by: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com> Co-authored-by: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com> * Move login.svg file * Make sure contexbar fits within the available space (#13467) * Make sure contexbar fits within the available space * Ensuring context bar moves above, no matter size of it. * Fixing apperance of connection-fixers * Info panes not loading prerequisites (#13486) * load relations immediately on init and remove call to non-existing function `appTabChange` on destroy * load relations immediately on init and remove now not-used eventsService * do not set layout gaps (#13496) * Nuget updates (#13478) * Updated nuget packages * Remove npoco update Co-authored-by: nikolajlauridsen <nikolajlauridsen@protonmail.ch> * Nuget updates (#13478) * Updated nuget packages * Remove npoco update Co-authored-by: nikolajlauridsen <nikolajlauridsen@protonmail.ch> * Bump version to final * V11/cherry pick flaky test (#13506) * V10/feature/fixing flaky acceptance test (#13473) * Bumped version * Handle external authentication providers (#13487) Co-authored-by: Jacob Overgaard <752371+iOvergaard@users.noreply.github.com> Co-authored-by: Corné Hoskam <choskam@hotmail.com> Co-authored-by: Ronald Barendse <ronald@barend.se> Co-authored-by: Niels Lyngsø <nsl@umbraco.dk> Co-authored-by: Bjarke Berg <mail@bergmania.dk> Co-authored-by: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com> Co-authored-by: nikolajlauridsen <nikolajlauridsen@protonmail.ch> Co-authored-by: Andreas Zerbst <73799582+andr317c@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
As mentioned in PR #13322, the global usings in the
Umbraco.Cmspackage should only be added whenImplicitUsingsare enabled in the consuming project.Testing can be done by first disabling implicit usings in the
Umbraco.Web.UI(before applying this PR) by adding<ImplicitUsings>false</ImplicitUsings>to the project file and adding explicit usings for theSystem.*andMicrosoft.*namespaces (see docs).Next apply this PR and notice you now also have to add explicit usings for
Umbraco.Cms.Core.DependencyInjectionandUmbraco.Extensions👍🏻