Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media Picker - upload button disabled bug #13383 #15115

Merged
merged 4 commits into from
Mar 5, 2024

Commits on Nov 2, 2023

  1. Media Picker - upload button disabled bug umbraco#13383

    Issue is around how the folder path is "got" on the initialisation - if it doesn't come from localstorage (which is wiped on logout- hence how I could recreate). The function gotoFolder(folder) has entityResource.getAncestors that builds the folder path if it's not set (which it isn't on first init) but this isn't on a promise or awaited.
    
    Modified the code that follows so it can only run once this returns by moving it to a separate function performGotoFolder(folder). It then has the path and on first open the editor can add images.
    
    I've tested the following scenarios and it seems to work (without breaking everything).
    
    Media picker with start node set.
    Media picker without start node
    User with limited media folders (e.g. can't see the start node).
    Seems to have resolved the issue.
    cheeseytoastie committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    6733f72 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2024

  1. Fix tabbing issue

    cheeseytoastie committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    5846c7f View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Configuration menu
    Copy the full SHA
    c4af7ff View commit details
    Browse the repository at this point in the history
  2. Fix whitespace

    nul800sebastiaan committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    ec4fadb View commit details
    Browse the repository at this point in the history