-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add health checks results to payload #15485
Add health checks results to payload #15485
Conversation
Hi there @erikjanwestendorp, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
Hey @erikjanwestendorp thanks a lot for your PR, someone on the core collaborators team will review this soon 😸 |
Hey @erikjanwestendorp, I tested this and it does work, although the json data comes back within response and the structure doesn't fully match what you share, mind that, there have been some changes since this PR. |
…eck-completed-webhook-event
@busrasengul Thanks for your review! Updated the PR. contrib is merged to this branch. |
Thank you @erikjanwestendorp |
Prerequisites
Description
Update the
HealthCheckCompletedWebhookEvent
. Add the health check results to the payload.Before:
After:
Test: