Fix UmbracoMapper InvalidOperationException due to concurrent modification of inner dictionary #15849
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Fixes issue #15830 by changing the inner Dictionary of _ctors to a ConcurrentDictionary.
This concurrency issue was encountered when mapping one type of object to multiple other objects (multiple mapping definitions) and performing multiple concurrent requests when Umbraco boots to a url with a view that did all the mappings at once.
The stack trace points to the UmbracoMapper.GetCtor method as the origin of the exception, indicating that the issue occurs during the retrieval of constructor mappings in concurrent scenarios.
Steps to test
Umbraco.Cms.Web.Common.PublishedModels.FrontPage
toSite.MyModel
.