Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V14: Revoke previous sessions when AllowConcurrentLogins is false #15892

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

elit0451
Copy link
Member

@elit0451 elit0451 commented Mar 15, 2024

Details

  • Revokes previously issued tokens of a user when Umbraco::CMS::Security::AllowConcurrentLogins is set to false.

Caution

Breaking: This PR adds a new parameter to the RevokeUserAuthenticationTokensNotificationHandler ctor;

Test

  • Make sure you are logged out;
  • Set Umbraco::CMS::Security::AllowConcurrentLogins to false;
  • Login as a user - verify that you can navigate around;
  • Open an incognito window;
  • Login as the same user;
  • In the first browser, verify that you will see a notification about "Session Expired";
  • Some changes need to be made on the FE to reflect recent changes on the BE - that's why you are not redirected automatically to the login screen;
  • Login again and verify that the same "Session Expired" flow happens again;
  • Set config to true - and verify that you can keep several active sessions at the same time.

@bergmania bergmania merged commit e9cfcf4 into v14/dev Mar 18, 2024
16 checks passed
@bergmania bergmania deleted the v14/feature/limit-concurrent-logins branch March 18, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants