Added missing locks and use timeout on all of them in ObjectCacheAppCache #15902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikolajlauridsen
approved these changes
Mar 19, 2024
nikolajlauridsen
deleted the
v14/bugfix/missing-locks-in-ObjectCacheAppCache
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures we have locks every time we interfere with the memory cache and hashset. Further, to ensure we do not potentially end in infinite deadlocks, I added a timeout to all of them
Fixes a comment here #15173 (comment)
Test
Ensure the cache still works.. I would expect the test suites to test this pretty intensive.
Ultimately, this fix is due to our hunt for the issue where the hashset suddenly is out of sync with the memory cache. So what ever you can think of as a test, would be nice.