-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V14: Blueprint CRUD endpoints #15947
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ueprintEditingService
…ument and blueprint models
… the rest of the item models
…ays be that for blueprints
…int-crud-endpoints
Migaroez
reviewed
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small remarks, i will test in the meantime
...Umbraco.Cms.Api.Management/Controllers/DocumentBlueprint/ByKeyDocumentBlueprintController.cs
Show resolved
Hide resolved
...Umbraco.Cms.Api.Management/Controllers/DocumentBlueprint/ByKeyDocumentBlueprintController.cs
Show resolved
Hide resolved
...mbraco.Cms.Api.Management/Controllers/DocumentBlueprint/DeleteDocumentBlueprintController.cs
Show resolved
Hide resolved
...mbraco.Cms.Api.Management/Controllers/DocumentBlueprint/DeleteDocumentBlueprintController.cs
Show resolved
Hide resolved
...mbraco.Cms.Api.Management/Controllers/DocumentBlueprint/UpdateDocumentBlueprintController.cs
Outdated
Show resolved
Hide resolved
Migaroez
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and behaves as expected 💪
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
/umbraco/management/api/v1/document-blueprint/{id}
/umbraco/management/api/v1/document-blueprint/{id}
/umbraco/management/api/v1/document-blueprint/{id}
/umbraco/management/api/v1/document-blueprint
/umbraco/management/api/v1/document-blueprint/from-document
IContentBlueprintEditingService
which will follow refactoring to clean up the shared implementation;Note
In both Create endpoints, the
parent
object in the request models is not currently utilized; this will make it easier in case we introduce blueprint containers later on:Bonus:
SchemaIdSelector
;GET /umbraco/management/api/v1/tree/document-blueprint/root
.GET /umbraco/management/api/v1/item/document-blueprint
:Test