Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an extension method for fetching a required user in a common way #15953

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Mar 27, 2024

Description

There are a few places where we expect a user to exist, and throw an exception if the user is not found. This PR adds an extension method to handle that kind of "required user fetching" in the same way across the codebase, instead of having individually implemented exception handling.

Copy link
Member

@elit0451 elit0451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💪 Merging

@elit0451 elit0451 merged commit 1866b61 into v14/dev Apr 2, 2024
16 checks passed
@elit0451 elit0451 deleted the v14/fix/clean-up-required-user-access branch April 2, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants