-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v14: Align Deploy interfaces, remove obsolete methods and default interface implementations #15965
Conversation
IMO should we look into a long term plan, about how to get these files out of the CMS. It looks like there is a failing unit test now. |
I've updated the test to include the I'm a bit split about removing these Deploy specific interfaces from the CMS though:
|
This cleans up some of the Deploy interfaces within the CMS:
IDataTypeConfigurationConnector.FromArtifact(...)
return type withIDataType.ConfigurationData
(following the data type refactor done in PR Datatype configuration refactor #13605);ArtifactBase<>.Alias
property nullability with theIArtifact
interface;ArtifactBase<>.Dependencies
collection is lazily set when empty (only allocating when being iterated);ShouldSerializeChecksum()
, since that was specific to the Newtonsoft.Json implementation (to avoid serializing theChecksum
property without having to take a reference to addJsonIgnore
attribute);