Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move manifest endpoints to their own, independent API group and fix access policies accordingly #15989

Merged
merged 12 commits into from
Apr 9, 2024

update OpenApi.json

1a62b6f
Select commit
Loading
Failed to load commit list.
Merged

Move manifest endpoints to their own, independent API group and fix access policies accordingly #15989

update OpenApi.json
1a62b6f
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v14/dev) succeeded Apr 9, 2024 in 41s

CodeScene PR Check

✅ Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method UmbracoBuilderExtensions.cs: AddUmbracoManagementApi

Annotations

Check warning on line 59 in src/Umbraco.Cms.Api.Management/DependencyInjection/UmbracoBuilderExtensions.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)

❌ Getting worse: Large Method 

AddUmbracoManagementApi increases from 70 to 71 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
View more details on CodeScene Delta Analysis