Rename Examine based entity search service

[kjac]

Prerequisites

• I have added steps to test this contribution in the description below

Description

As correctly pointed out in this comment, the newly introduced IExamineEntitySearchService is counter productive towards the eventual goal of decoupling ourselves a little more from Examine.

Furthermore, the naming in itself bleeds technology, which is clearly a mistake on yours truly when implementing the thing.

This PR renames it to IIndexedEntitySearchService instead. It was the best I could come up with 🙈

Testing this PR

Everything should still work exactly as before. Steps from #15972 can be reused, but basically - if document items can be searched, all is good. Don't forget to rebuild the Examine indexes, though 👍

[Migaroez]

Naming wise IIndexedEntitySearchService conveys that there is a requirement/desire to use an indexing mechanism, but in the methods defined on the interface there is no such explicit requirement.
So in my opinion we can just reduce it to IEntitySearchService as the only requirement is that the implementing class returns Entities based on search criteria

For the name of the implementing service, i would argue it doesn't matter if you bleed technology and it makes a lot of sense to be specific so it is more apparent of how/what the service does.

ExamineContentSearchService : IEntitySearchService
We use examine to only get Content (document,media,member) for specific search criteria

[Migaroez]

Due to some non obvious collisions, we will stick to the naming. The purpose of the similar interfaces have been clarified 🥳.

Everything seems to work as before 💪

[bielu]

@Migaroez alternative name could be "IStorageEntitySearchService", which doesn't imply indexing, but that it looks into specific storage in this case examine index :)
cc: @kjac

[Migaroez]

@Migaroez alternative name could be "IStorageEntitySearchService", which doesn't imply indexing, but that it looks into specific storage in this case examine index :) cc: @kjac

I strongly disagree, storage implies persistence. Examine indexes do not persist entities they index them with possibly altered/partial data.

[bielu]

@Migaroez storage != persistence storage :) but getting your point