Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V14: Deleted code marked as obsolete for V14 #15998

Merged
merged 30 commits into from
Apr 9, 2024
Merged

V14: Deleted code marked as obsolete for V14 #15998

merged 30 commits into from
Apr 9, 2024

Conversation

elit0451
Copy link
Member

@elit0451 elit0451 commented Apr 5, 2024 •
edited
Loading

Details

  • Deleted code marked as obsolete for V14 & some default implementations (relying on the legacy code);
    • Including obsoletions related to Delivery API;
    • Including obsoletions related to XPath - some classes had to be moved to the NuCache project and were made internal (plus, obsoleted for v15);
    • Obsoleted whole unused classes instead of deleting their obsoleted implementation;
    • Fixed tests referencing the obsoleted implementation and removed no longer needed ones;
    • Added new obsoletions to constructors since some params were used in the deleted implementation.

Test

  • Run a smoke test.

@elit0451
Obsoletions related to Delivery API
9f6254d
@elit0451
Fix TypeLoader and TypeFinder tests
f05fe4a
@elit0451
Remove obsolete and default implementations of IFileSource and IFileT…
f8f19d0 
…ypeCollection
@elit0451
More Delivery API related obsoletions
201318e
@elit0451
VariationContextAccessor related
05f6d86
@elit0451
ValueFactories obsoletion and fix references
77b4417
@elit0451
ValueSetBuilders obsoletions
6d78569
@elit0451
ValueConverters obsoletions
ab7c665
@elit0451
Other obsolete ctors and methods
c761a6a
@elit0451
Forgotten VariationContextAccessor obsoletion
99602c8
@elit0451
More obsoletions
5f5ef73
@elit0451
XPath related obsoletions
910ae7e
@elit0451
Revert XmlHelper changes
39c486e
@elit0451
Delete RenamedRootNavigator and its tests
778ff25
@elit0451
Fix test
29b935b
@elit0451
XmlHelper obsoletion
2d5f9e6
@elit0451
Return null instead of GetXPathValue
e110c10
@elit0451
Obsolete entire class instead
cc765e8
@elit0451
Remove XPath obsoletions from IPublishedCache
b7689e7
@elit0451
Remove XPath-related if-block that is no longer needed
ae33769
@elit0451
Change obsolete msg for classes needed for NuCache
46cd03b
@elit0451
Moving classes to NuCache and making them internal
682ae8c
@elit0451
Remove more XPath-related obsoletions
8e072d8
@elit0451
Remove NavigableNavigator and its tests
ef58a7b
@elit0451
Cleanup
6724f7b
@elit0451
Remove Xpath references from tests
69d5bd8
@elit0451
Merge remote-tracking branch 'origin/v14/dev' into v14/feature/obsole…
015d4f6 
…tion-cleanup
@elit0451
Revert interface deletion in MediaCache
d8af831
@elit0451 @Nuklon
Using XOR operation
a4e0b3e 
Co-authored-by: Nuklon <Nuklon@users.noreply.github.com>
@Zeegaan
Copy link
Member

Zeegaan commented Apr 8, 2024

Looks good, just need the merge conflicts resolved then we're ready to merge 🚀

@elit0451
Merge remote-tracking branch 'origin/v14/dev' into v14/feature/obsole…
0d1a75a 
…tion-cleanup

# Conflicts:
#	src/Umbraco.Core/PropertyEditors/JsonPropertyIndexValueFactoryBase.cs
#	src/Umbraco.Core/PropertyEditors/TagPropertyIndexValueFactory.cs
#	src/Umbraco.Core/PropertyEditors/ValueConverters/MemberGroupPickerValueConverter.cs
#	src/Umbraco.Core/PublishedCache/PublishedCacheBase.cs
#	src/Umbraco.Core/Xml/UmbracoXPathPathSyntaxParser.cs
#	src/Umbraco.Infrastructure/Examine/BaseValueSetBuilder.cs
#	src/Umbraco.Infrastructure/Examine/MemberValueSetBuilder.cs
#	src/Umbraco.Infrastructure/Logging/Viewer/LogViewerConfig.cs
#	src/Umbraco.Infrastructure/PropertyEditors/ValueConverters/MediaPickerWithCropsValueConverter.cs
#	src/Umbraco.Infrastructure/Security/IdentityMapDefinition.cs
@Zeegaan Zeegaan merged commit 9c18cd2 into v14/dev Apr 9, 2024
15 of 16 checks passed
@Zeegaan Zeegaan deleted the v14/feature/obsoletion-cleanup branch April 9, 2024 07:06
@Zeegaan Zeegaan added the project/bellissima AKA "the new backoffice" label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuklon Nuklon Nuklon left review comments

Assignees
No one assigned
Labels
project/bellissima AKA "the new backoffice" release/14.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elit0451 @Zeegaan @Nuklon @bergmania