Remove RTE embedded image handling + clean up file upload configuration #16025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Migaroez
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The embedded image handling for the RTE (introduced in #14546) was written for TinyMCE 4 and no longer needs to happen in V14. As it has not yet been ported over to V14, I have simply deleted the empty stub (
FindAndPersistEmbeddedImages).In a previous PR (#16021) I actually ported the functionality to V14. While implementing tests for that PR, I encountered a silly error in our file upload configuration; the
FileExtensionsshould be a simple string collection, not a collection ofFileExtensionConfigItem. In fact we no longer needFileExtensionConfigItemfor V14.As it turns out, the marker interface
IFileExtensionsConfigis also a V13 specific thing, so that can be removed for V14 as well.Since I had most of the test setup in place for the previous PR, I have reused that to create new tests for this PR. These tests in turn prove the necessity of the
FileUploadConfigurationchanges - albeit indirectly.There are no real functional changes in this PR - only a slight clean-up 😉