v14: Update to NJsonSchema 11.0.0 and use SystemTextJsonSchemaGeneratorSettings
#16030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronaldbarendse
force-pushed
the
v14/feature/remove-newtonsoftjson-jsonschema
branch
from
8e432e9
to
9945dac
Compare
|
I noticed #15987 already updated the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #16029, this removes the transitive dependency on
Newtonsoft.Jsonby updatingNJsonSchemato 11.0.0 (which uses STJ by default).I've verified the same
appsettings.schema.Umbraco.Cms.jsonis generated by renaming the existing file, applying this PR, rebuilding the solution and comparing the newly generated file with the renamed one.