-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V14] import/export media/document type endpoints #16100
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added analyze endpoint to extract relevant data without fully processing the file - split up import endpoints into POST & PUT - removed availableAtAction as the new endpoint allows clients to call the POST/PUT endpoints with confidence - Added a new service that is responsible for turning temp files into Import compatible XML and being able to extracty partial information from it
# Conflicts: # src/Umbraco.Cms.Api.Management/DependencyInjection/UmbracoBuilderExtensions.cs # src/Umbraco.Core/DependencyInjection/UmbracoBuilder.cs
kjac
reviewed
May 6, 2024
src/Umbraco.Core/Services/ImportExport/TemporaryFileToXmlImportService.cs
Outdated
Show resolved
Hide resolved
kjac
reviewed
May 6, 2024
src/Umbraco.Core/Services/ImportExport/TemporaryFileToXmlImportService.cs
Outdated
Show resolved
Hide resolved
kjac
reviewed
May 6, 2024
src/Umbraco.Core/Services/ImportExport/ContentTypeImportService.cs
Outdated
Show resolved
Hide resolved
kjac
reviewed
May 6, 2024
src/Umbraco.Cms.Api.Management/Controllers/DocumentType/ImportExistingDocumentTypeController.cs
Outdated
Show resolved
Hide resolved
kjac
reviewed
May 6, 2024
src/Umbraco.Cms.Api.Management/Controllers/DocumentType/ImportNewDocumentTypeController.cs
Outdated
Show resolved
Hide resolved
kjac
reviewed
May 6, 2024
src/Umbraco.Cms.Api.Management/Controllers/MediaType/ImportExistingMediaTypeController.cs
Outdated
Show resolved
Hide resolved
kjac
reviewed
May 6, 2024
src/Umbraco.Cms.Api.Management/Controllers/MediaType/ImportNewMediaTypeController.cs
Outdated
Show resolved
Hide resolved
kjac
reviewed
May 6, 2024
src/Umbraco.Core/Services/ImportExport/MediaTypeImportService.cs
Outdated
Show resolved
Hide resolved
kjac
reviewed
May 6, 2024
src/Umbraco.Core/Services/ImportExport/MediaTypeImportService.cs
Outdated
Show resolved
Hide resolved
I have pushed a little bit of clean-up and pedantic formatting 🙈 and there are a few comments you can look at. Also, I think the OpenAPI.json file needs regenerating to contain the new APIs? |
# Conflicts: # src/Umbraco.Cms.Api.Management/OpenApi.json
kjac
approved these changes
May 17, 2024
Frontend implementation of this will be after 14.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This adds the import/export functionality of v13 and below into the management API. The main differences being:
Testing
ContentTypeImportOperationStatusResult()
&MediaTypeImportOperationStatusResult()
for inspiration.