Support member saving Cancel #16147
Merged
Support member saving Cancel #16147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, tests good 🚀 |
Zeegaan
deleted the
v14/bugfix/15152-Handle-when-member-save-is-cancelled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15152
This PR adds support for cancelling a member saving operation.
Remarks
This is fixed on V14, as we already have updated the MemberService.Save to be able to communicate back the error messages. For earlier versions it is just a void method.
Test
The error message is still not picked up by the frontend, but we know thats a general missing thing. To test follow the instructions on the issue, and note the "Umb-Notifications" header in the request