Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14] Add missing alias and id to usergroup related api models #16154

Merged
merged 5 commits into from
May 3, 2024

Conversation

Migaroez
Copy link
Contributor

Prerequisites

  • I have added steps to test this contribution in the description below

Description

  • Added alias to the usergroup create/update request models to specify the alias of usergroup
  • Added alias to the usergroup response/item models to read the alias
  • Added an optional id to the usergroup createmodel to specify the id of the newly created usergroup
  • refactored some duplicate code, namespacecleanup, ...

Testing

Check whether specifying/updating a usergroup alias trough the post/put endpoints is reflected in all get endpoints
Check whether specifying the id is reflected in the get endpoints
Check whether leaving the id blank in the post results in an id being assigned

Copy link
Contributor

@kjac kjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tests out good too 👍

@kjac kjac mentioned this pull request Apr 26, 2024
1 task
@nielslyngsoe nielslyngsoe merged commit f9c0235 into v14/dev May 3, 2024
4 of 7 checks passed
@nielslyngsoe nielslyngsoe deleted the v14/fix/add-user-group-alias-and-id branch May 3, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants