Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist claims from OnExternalLogin event #16180

Merged

Conversation

bergmania
Copy link
Member

Description

This PR Ensures claims added in the OnExternalLogin are actually persisted in the tokens we store.

The issue before was we did not use the same ClaimsPricipal when calling OpenIddict as the one used doing External Login

Copy link
Contributor

@kjac kjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 💪

@bergmania bergmania changed the title Persist claims from InExternalLogin event Persist claims from OnExternalLogin event Apr 29, 2024
@bergmania bergmania merged commit 976146b into v14/dev Apr 29, 2024
16 checks passed
@bergmania bergmania deleted the v14/bugfix/persist-claims-from-onexternallogin-event branch April 29, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants