Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Management api should use datetimeoffset #16196

Merged

Conversation

bergmania
Copy link
Member

Description

Builds on top of #16170

This updates datetime to datetimeoffset in the management api and uses the LocalDateTime when using it.

Test

  • Ensure the endpoints continue to work
  • Try to use times with timezone info in management api, and ensure the times are "converted" to the server time

Copy link
Contributor

@nikolajlauridsen nikolajlauridsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Base automatically changed from v14/fix/move-audit-log-endpoints to v14/dev May 1, 2024 10:07
…ugfix/management-api-should-use-datetimeoffset

# Conflicts:
#	src/Umbraco.Cms.Api.Management/Controllers/Document/GetAuditLogDocumentController.cs
#	src/Umbraco.Cms.Api.Management/Controllers/Media/GetAuditLogMediaController.cs
#	src/Umbraco.Core/Services/AuditService.cs
@nikolajlauridsen nikolajlauridsen merged commit 2260da2 into v14/dev May 7, 2024
15 checks passed
@nikolajlauridsen nikolajlauridsen deleted the v14/bugfix/management-api-should-use-datetimeoffset branch May 7, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants