Add GetAllAsync overload without parameter simplify getting all or by keys #16264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #16230 (comment), changing
GetAllAsync()
to return all data types if no keys are specified requires conditional checks when supplying a dynamic list of keys (as an empty list of keys would now return all data types, instead of 0).To avoid having to manually check the length of the list of keys, this PR adds an overload without the parameter that returns all data types and reverts the previous method to only return data types for the specified keys (so an empty list of keys results in an empty list of data types again).
This should also prevent similar bugs in the future (or in packages). The only discrepancy would be that
GetAll(params int[] ids)
still returns all data types if an empty list of IDs is specified), but this methods has already been obsoleted.