Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V14: Merge 13 to 14 #16340

Merged
merged 31 commits into from
May 22, 2024

Remove obselete test

7a4bee3
Select commit
Loading
Failed to load commit list.
Merged

V14: Merge 13 to 14 #16340

Remove obselete test
7a4bee3
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v14/dev) failed May 22, 2024 in 37s

CodeScene PR Check

Code Health Quality Gates: FAILED

  • Declining Code Health: 7 findings(s) 🚩
  • Improving Code Health: 7 findings(s) ✅

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Overall Code Complexity EagerMatcherPolicy.cs
  • Complex Conditional EagerMatcherPolicy.cs: ApplyAsync
  • Complex Conditional EagerMatcherPolicy.cs: HandleInstallUpgrade
  • Complex Method EagerMatcherPolicy.cs: ApplyAsync
  • Bumpy Road Ahead EagerMatcherPolicy.cs: ApplyAsync
  • Bumpy Road Ahead EagerMatcherPolicy.cs: HandleInstallUpgrade
  • Complex Method EagerMatcherPolicy.cs: HandleInstallUpgrade

✅ Improving Code Health:

  • Complex Method UmbracoRouteValueTransformer.cs: TransformAsync
  • Bumpy Road Ahead DeliveryApiJsonTypeResolver.cs: GetTypeInfo
  • Complex Conditional Property.cs: GetSourceValue
  • Bumpy Road Ahead Property.cs: Property
  • Overall Code Complexity Property.cs
  • Deep, Nested Complexity Property.cs: Property
  • Code Duplication UmbracoRequestPathsTests.cs

Annotations

Check notice on line 158 in src/Umbraco.PublishedCache.NuCache/Property.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)

✅ No longer an issue: Complex Conditional

GetSourceValue no longer has a complex conditional

Check notice on line 91 in src/Umbraco.PublishedCache.NuCache/Property.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)

✅ No longer an issue: Bumpy Road Ahead

Property is no longer above the threshold for logical blocks with deeply nested code

Check notice on line 1 in src/Umbraco.PublishedCache.NuCache/Property.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)

✅ No longer an issue: Overall Code Complexity

The mean cyclomatic complexity in this module is no longer above the threshold

Check notice on line 91 in src/Umbraco.PublishedCache.NuCache/Property.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)

✅ No longer an issue: Deep, Nested Complexity

Property is no longer above the threshold for nested complexity depth

Check notice on line 41 in src/Umbraco.Cms.Api.Delivery/Json/DeliveryApiJsonTypeResolver.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)

✅ No longer an issue: Bumpy Road Ahead

GetTypeInfo is no longer above the threshold for logical blocks with deeply nested code

Check warning on line 130 in src/Umbraco.Web.Website/Routing/EagerMatcherPolicy.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)

❌ New issue: Complex Method

ApplyAsync has a cyclomatic complexity of 15, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 227 in src/Umbraco.Web.Website/Routing/EagerMatcherPolicy.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)

❌ New issue: Complex Method

HandleInstallUpgrade has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 126 in src/Umbraco.Web.Website/Routing/EagerMatcherPolicy.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)

❌ New issue: Complex Conditional

ApplyAsync has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.

Check warning on line 212 in src/Umbraco.Web.Website/Routing/EagerMatcherPolicy.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)

❌ New issue: Complex Conditional

HandleInstallUpgrade has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.

Check warning on line 130 in src/Umbraco.Web.Website/Routing/EagerMatcherPolicy.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)

❌ New issue: Bumpy Road Ahead

ApplyAsync has 3 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 227 in src/Umbraco.Web.Website/Routing/EagerMatcherPolicy.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)

❌ New issue: Bumpy Road Ahead

HandleInstallUpgrade has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 1 in src/Umbraco.Web.Website/Routing/EagerMatcherPolicy.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)

❌ New issue: Overall Code Complexity

This module has a mean cyclomatic complexity of 4.57 across 7 functions. The mean complexity threshold is 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.

Check notice on line 101 in src/Umbraco.Web.Website/Routing/UmbracoRouteValueTransformer.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)

✅ Getting better: Complex Method

TransformAsync decreases in cyclomatic complexity from 16 to 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 1 in tests/Umbraco.Tests.UnitTests/Umbraco.Core/Published/PublishedContentVarianceTests.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)

ℹ Getting worse: Primitive Obsession

The ratio of primitive types in function arguments increases from 78.57% to 85.00%, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.

Check notice on line 1 in tests/Umbraco.Tests.UnitTests/Umbraco.Core/Published/PublishedContentVarianceTests.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)

ℹ Getting worse: String Heavy Function Arguments

The ratio of strings in function arguments increases from 78.57% to 85.00%, threshold = 39.0%. The functions in this file have a high ratio of strings as arguments. Avoid adding more.

Check notice on line 1 in tests/Umbraco.Tests.UnitTests/Umbraco.Core/Routing/UmbracoRequestPathsTests.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)

✅ No longer an issue: Code Duplication

The module no longer contains too many functions with similar structure