Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V14: Add required dependency to management api #16532

Merged
merged 3 commits into from
Jun 3, 2024

Update src/Umbraco.Cms.Api.Common/DependencyInjection/UmbracoBuilderA…

15e4348
Select commit
Loading
Failed to load commit list.
Merged

V14: Add required dependency to management api #16532

Update src/Umbraco.Cms.Api.Common/DependencyInjection/UmbracoBuilderA…
15e4348
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v14/dev) succeeded May 31, 2024 in 25s

CodeScene PR Check

✅ Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩

  • Affected Hotspots: 1 files(s) 🔥

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method UmbracoBuilderExtensions.cs: AddUmbracoManagementApi 🔥

Annotations

Check warning on line 25 in src/Umbraco.Cms.Api.Management/DependencyInjection/UmbracoBuilderExtensions.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)

❌ Getting worse: Large Method 

AddUmbracoManagementApi increases from 74 to 75 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
View more details on CodeScene Delta Analysis