Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V14: No nodes page - fix broken logo URL + replace old background image #16534

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

matthew-darby
Copy link
Contributor

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

14.0.0

1. Reinstates the new background image added by @BatJan in #14392

2. Fixes the broken logo URL on the "no nodes" page

screenshot_1717162885

Copy link

github-actions bot commented May 31, 2024

Hi there @matthew-darby, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@matthew-darby matthew-darby changed the title No nodes page - fix broken logo URL + replace old background image V14: No nodes page - fix broken logo URL + replace old background image May 31, 2024
@Matthew-Wise
Copy link
Contributor

Hi @matthew-darby

Thanks for the PR fixing this regression :) one of the core Collab's team will review it soon.

thanks
Matt

@Matthew-Wise Matthew-Wise self-assigned this Jun 1, 2024
@Matthew-Wise Matthew-Wise merged commit 0bb46b9 into umbraco:contrib Jun 10, 2024
14 checks passed
@Matthew-Wise
Copy link
Contributor

Hi @matthew-darby,
Sorry for the delay! I looked at this a while ago and forgot to merge it

Thanks again for fixing and improving that screen, I see that cheeky move to webp :)

Matt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants